Skip to content

Conversation

Ryu-ga
Copy link
Contributor

@Ryu-ga Ryu-ga commented Oct 6, 2023

In Sonoma14.1 betas, FBSSceneSettings seems to have - (CGRect) frame, FBSSceneSettingsCore does.
It can be swizzled by using exchangeMethod.
These code needs to be edited for Sonoma under 14.1betas.

Copy link
Member

@XuYicong XuYicong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on MacOS 14.1 beta (23B5056e and 23B5046f), working as expected.

Copy link
Member

@TheMoonThatRises TheMoonThatRises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merely style, but a space between if and parenthesis would be nice. Other than that, LGTM and works Sonoma Beta 23B5067a (which came out today).

@ghost ghost merged commit 0cb5336 into PlayCover:3.0.0-staging Oct 26, 2023
@CJMOB

This comment was marked as off-topic.

@ephraimduncan
Copy link

Doesn't work on Sonoma 14.4.0

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants