Hide the option to add a mouse controlled joystick in circle menu #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuYicong
pushed a commit
to XuYicong/PlayTools
that referenced
this pull request
Mar 4, 2023
…yCover#86) * Replaced all strings with keys Revamped the entire localizations with up-to-date sentences written with the current situation in mind * Wiped all previous translations Lots of old translations no longer apply, and it is a good idea to get people to translate for the app again according to the current situation now that the base localization (English) is accurate and up-to-date * Tuned code for proper building Fixed some issues with the locale files * Attempting to resolve conflict ignore this 💀 * Reverted whatever I just did * ;-; forgot to stage a file * Reverted unintentional changes to code Reverted button style, brought back "soundAlert.*" * Salvaged some german locales * Restored french translation of sound alert * Tuned some UI aspect of things Adjusted minimum window size for fitting to 4 columns of apps just right, fixed a typo that exposed raw string key, and added some horizontal paddings to search bar for better aesthetics Modded various UI aspect of things used same style as every other buttons in UI for consistency Trimmed paddings on bottom bar Adjusted padding for even paddings around buttons (because there is an un-removable safe area padding at the bottom of the window (which i cant seem to nuke by "ignoreSafeArea()") ) Added a thin border to search bar for aesthetic purposes and ease of use by creating that contrast between search bar and background * Added Chinese locales :chef_kiss: Updated my Chinese locale updated to the new formatting used * Ironed out locales formatting Added spacings to separate different types of messages and changed some keys for consistency Tuned ".ipa" parts for consistency Updated text in setup view * Repositioned crash button moved crash button to the left of "Experiencing issues?" button to save some space and avoid taking up unnecessary row of space just for the 1 button * Remove unnecessary imports SwiftUI is all we need ✨ * Making changes according to isaac * Changed grammar errors and cleaned code According to Isaac's comments * Modded upstream code to match current changes * Updated locale to work with PlayCover#108 Added and mapped keys to strings Updated more UI to work with locale Reverted signing settings Reverted changes Updated locale * Removed unnecessary @State attribute * Removed "private" attrib for code building * Changed locale based on suggestions * Reverted UI changes mainly the bottom two buttons in swttings view * Updated locale to work with latest PR * Changed locale based on suggestions Updated locale to work with latest PR * Reverted UI changes mainly the bottom two buttons in swttings view * ignore project.pbxproj * Revert "ignore project.pbxproj" This reverts commit de009853e1892600129fb0aeaa2f6a5cc2b6ef10. Reverted ignore settings * Reverted UI change suggested by Depal * Reverted more UI suggested by Isaac Added corner radius * Reverted UI from Isaac's comments Fixed some changes * Revert "Remove unnecessary imports" This reverts commit 686d1a73f332d7428eb81543821a2fe4fb2df839.
XuYicong
pushed a commit
to XuYicong/PlayTools
that referenced
this pull request
Mar 4, 2023
…yCover#121) * Replaced all strings with keys Revamped the entire localizations with up-to-date sentences written with the current situation in mind * Wiped all previous translations Lots of old translations no longer apply, and it is a good idea to get people to translate for the app again according to the current situation now that the base localization (English) is accurate and up-to-date * Tuned code for proper building Fixed some issues with the locale files * Attempting to resolve conflict ignore this 💀 * Reverted whatever I just did * ;-; forgot to stage a file * Reverted unintentional changes to code Reverted button style, brought back "soundAlert.*" * Salvaged some german locales * Restored french translation of sound alert * Tuned some UI aspect of things Adjusted minimum window size for fitting to 4 columns of apps just right, fixed a typo that exposed raw string key, and added some horizontal paddings to search bar for better aesthetics Modded various UI aspect of things used same style as every other buttons in UI for consistency Trimmed paddings on bottom bar Adjusted padding for even paddings around buttons (because there is an un-removable safe area padding at the bottom of the window (which i cant seem to nuke by "ignoreSafeArea()") ) Added a thin border to search bar for aesthetic purposes and ease of use by creating that contrast between search bar and background * Added Chinese locales :chef_kiss: Updated my Chinese locale updated to the new formatting used * Ironed out locales formatting Added spacings to separate different types of messages and changed some keys for consistency Tuned ".ipa" parts for consistency Updated text in setup view * Repositioned crash button moved crash button to the left of "Experiencing issues?" button to save some space and avoid taking up unnecessary row of space just for the 1 button * Remove unnecessary imports SwiftUI is all we need ✨ * Making changes according to isaac * Changed grammar errors and cleaned code According to Isaac's comments * Modded upstream code to match current changes * Updated locale to work with PlayCover#108 Added and mapped keys to strings Updated more UI to work with locale Reverted signing settings Reverted changes Updated locale * Removed unnecessary @State attribute * Removed "private" attrib for code building * Changed locale based on suggestions * Reverted UI changes mainly the bottom two buttons in swttings view * Updated locale to work with latest PR * Changed locale based on suggestions Updated locale to work with latest PR * Reverted UI changes mainly the bottom two buttons in swttings view * ignore project.pbxproj * Revert "ignore project.pbxproj" This reverts commit de009853e1892600129fb0aeaa2f6a5cc2b6ef10. Reverted ignore settings * Reverted UI change suggested by Depal * Reverted more UI suggested by Isaac Added corner radius * Reverted UI from Isaac's comments Fixed some changes * Revert "Remove unnecessary imports" This reverts commit 686d1a73f332d7428eb81543821a2fe4fb2df839. * Addes keys to AppView.swift * Update locale for PlayCover#95 * Updated keys to work with locale SetupView.swift
XuYicong
pushed a commit
to XuYicong/PlayTools
that referenced
this pull request
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of people get confued between "rounded square mouse" and "circle mouse". Most of them actually needs "circle mouse", which is used to control camera. "rounded square mouse" is used to control movement.
To avoid confusion to new comers, I removed the option to add a "rounded square mouse" in keymapping editor's circle menu.
For people who do need this, you can set a mouse controlled joystick by clicking any mouse button except left mouse button (i.e. right mouse button or middle mouse button) while focused on a WASD joystick.
It would be better if we have text to describe what can be done to add a new mapping and to an existing mapping. I have researched a little and find it impossible under the current editor architecture. Either a refactor to the current editor or a complete new editor is needed to achieve this.
There is a known issue that mouse button does not work in editor without previously enabled keymapping. This issue is left unfixed in this PR to avoid conflict with other PRs.