Fix: Default app size now shows normally and other Adaptive fixes plus responsive fix on default #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reverting cleanup * Testing removing new scaling methods for default * Revert to new methods for testing * Setting orientation to 1 * 4 * commenting suspect stuff * 12 * sd * removing FBS * test * returning back to normal * Test * a * test * x * a * a * a * as * 1 * as * así * aa * as * Change names * testing something * testing 2 * more test * 12 * return * 123 * Testing defaults and auto fix * Testing c * is this ready? * test * 1 * returning adaptive
|
Some cleaning at the code is necessary, but tests are welcome |
Removing All references to PlayScreenDefault.swift
* testing changing to default bounds * Update project.pbxproj (#2) Removing All references to PlayScreenDefault.swift * test 2 * rest * test * as * asd * test * 123 * Adding inverseScreenValues to settings * Reduced code and added ternaries * added else when inverseScreenValues is false (might rework
|
Tests of #77 (2a8b824) with PlayCover/PlayCover#781 ( PlayCover/PlayCover@b0e62b1) on macOS 13.1. Angry Birds Space com.rovio.AngryBirdsSpace
Dadish com.thomasyoung.gooddadish
Genshin Impact com.miHoYo.GenshinImpact
|
1 task
* testing changing to default bounds * Update project.pbxproj (#2) Removing All references to PlayScreenDefault.swift * test 2 * rest * test * as * asd * test * 123 * Adding inverseScreenValues to settings * Reduced code and added ternaries * added else when inverseScreenValues is false (might rework * Test to fix pre MacOS 13.2 * Check this out * Using float instead of string * v2 * test * lets see * adding print * NSLog(@"macOS version: %f", [[PlaySettings shared] macOSVersion]); * [[PlaySettings shared] macOSVersion] rounded * adding 00000 to every float * testing * return back to normal double * Forgot about floating point error * more than 13.1 * more * 13.199 * setting to latest macOS version * more floating error and macOS fixes * reduced lines and fix some errors * Update project.pbxproj
|
@Depal1 is it possible to test this? |
Depal1
requested changes
Feb 7, 2023
There was a problem hiding this comment.
All tests where performed on macOS 13.1 with the commits fd6dfbd and PlayCover/PlayCover@e74e697 of PlayTools and PlayCover respectively.
App default seems to work as intended on macOS 13.1, both in resizable windows and fixed frames.
The regression regarding improper view window position in non-app-default settings, introduced in changes after the 2.0.7 PlayTools tag for macOS 13.1 and previous versions, is still present on Angry Birds Space. It is unbeknownst to me if it is present on 13.2 too.
A similar regression is present on Plague Inc., which can't be displayed correctly with either Fix window issues on or off, showing in both cases as in the following picture (1080p 16:9).
Tests were also made changing the aspect ratio, in order to visually confirm that window settings were indeed being changed on a general basis. Hence, Fix window issues might not be working correctly. Further on this hypothesis, Angry Birds Space is showing in the same way when either Fix window issues is on or off, in contraposition to the behaviour in previous tests.
Rather than checking for macOS 13.2 from PlayCover and giving that information to PlayTools, those checks could be done from PlayTools itself using the corresponding check availability attributes both in Swift and Objective-C, using the equivalent iOS 16.3 check for macOS 13.2 since PlayTools is iOS and then converted via Mac Catalyst. https://developer.apple.com/documentation/swift/marking-api-availability-in-objective-c
It is encouraged to test such an approach first. Otherwise, the purpose of splitting PlayCover from PlayTools is partly defeated by making PlayTools strictly dependent from PlayCover, and worthless as a standalone framework unnecessarily. The former instance has the potential to reduce code too.
|
The toggle Fix window issues is not meant to work in 13.1 just 13.2 and up. sorry that I forgot to add that check for that in Frontend |
…oggle enabled (#5) * test disabling FBSDisplayMode * disabling FBS * Adding experimental fix toggle to fix responsiveness * adding an extra log * extra * moving the function to a better place * back to another place * added CheckResizabilityHasRun * Testing some stuff * name issue * added some comments to test * added fuction stop * True to yes * Changed yes to no * adding observer for resize * adding chess * test * back again * Removing extra check for a future commit
|
@Depal1 sorry, the toggle for fix screen issue is not meant to work for 13.1 just 13.2 and up. |
Depal1
reviewed
Feb 13, 2023
1 task
Depal1
approved these changes
Feb 15, 2023
XuYicong
pushed a commit
to XuYicong/PlayTools
that referenced
this pull request
Mar 3, 2023
…s responsive fix on default (PlayCover#77)
XuYicong
pushed a commit
to XuYicong/PlayTools
that referenced
this pull request
Mar 4, 2023
Removed 'Colr' class and references to old PlayCover pink
IsaacMarovitz
pushed a commit
to IsaacMarovitz/PlayTools
that referenced
this pull request
Mar 16, 2023
…s responsive fix on default (PlayCover#77) * Fix for default screen * Code cleanup * setting @objc to scene control vars * PR to make default size work correctly (#1) * Reverting cleanup * Testing removing new scaling methods for default * Revert to new methods for testing * Setting orientation to 1 * 4 * commenting suspect stuff * 12 * sd * removing FBS * test * returning back to normal * Test * a * test * x * a * a * a * as * 1 * as * así * aa * as * Change names * testing something * testing 2 * more test * 12 * return * 123 * Testing defaults and auto fix * Testing c * is this ready? * test * 1 * returning adaptive * Delete PlayScreenDefault.swift * Update project.pbxproj Removing All references to PlayScreenDefault.swift * Adds fix for some apps with adaptive display enabled (#3) * testing changing to default bounds * Update project.pbxproj (#2) Removing All references to PlayScreenDefault.swift * test 2 * rest * test * as * asd * test * 123 * Adding inverseScreenValues to settings * Reduced code and added ternaries * added else when inverseScreenValues is false (might rework * Adds MacOSVersion to plist and a 'fix' for screen issue (PlayCover#4) * testing changing to default bounds * Update project.pbxproj (#2) Removing All references to PlayScreenDefault.swift * test 2 * rest * test * as * asd * test * 123 * Adding inverseScreenValues to settings * Reduced code and added ternaries * added else when inverseScreenValues is false (might rework * Test to fix pre MacOS 13.2 * Check this out * Using float instead of string * v2 * test * lets see * adding print * NSLog(@"macOS version: %f", [[PlaySettings shared] macOSVersion]); * [[PlaySettings shared] macOSVersion] rounded * adding 00000 to every float * testing * return back to normal double * Forgot about floating point error * more than 13.1 * more * 13.199 * setting to latest macOS version * more floating error and macOS fixes * reduced lines and fix some errors * Update project.pbxproj * Update project.pbxproj * Update PlaySettings.swift * Enables responsiveness for some apps for default screen settings if toggle enabled (PlayCover#5) * test disabling FBSDisplayMode * disabling FBS * Adding experimental fix toggle to fix responsiveness * adding an extra log * extra * moving the function to a better place * back to another place * added CheckResizabilityHasRun * Testing some stuff * name issue * added some comments to test * added fuction stop * True to yes * Changed yes to no * adding observer for resize * adding chess * test * back again * Removing extra check for a future commit * changed macos check to ios check * Remove macOSVersion
IsaacMarovitz
pushed a commit
to IsaacMarovitz/PlayTools
that referenced
this pull request
May 8, 2023
…s responsive fix on default (PlayCover#77) * Fix for default screen * Code cleanup * setting @objc to scene control vars * PR to make default size work correctly (#1) * Reverting cleanup * Testing removing new scaling methods for default * Revert to new methods for testing * Setting orientation to 1 * 4 * commenting suspect stuff * 12 * sd * removing FBS * test * returning back to normal * Test * a * test * x * a * a * a * as * 1 * as * así * aa * as * Change names * testing something * testing 2 * more test * 12 * return * 123 * Testing defaults and auto fix * Testing c * is this ready? * test * 1 * returning adaptive * Delete PlayScreenDefault.swift * Update project.pbxproj Removing All references to PlayScreenDefault.swift * Adds fix for some apps with adaptive display enabled (#3) * testing changing to default bounds * Update project.pbxproj (#2) Removing All references to PlayScreenDefault.swift * test 2 * rest * test * as * asd * test * 123 * Adding inverseScreenValues to settings * Reduced code and added ternaries * added else when inverseScreenValues is false (might rework * Adds MacOSVersion to plist and a 'fix' for screen issue (PlayCover#4) * testing changing to default bounds * Update project.pbxproj (#2) Removing All references to PlayScreenDefault.swift * test 2 * rest * test * as * asd * test * 123 * Adding inverseScreenValues to settings * Reduced code and added ternaries * added else when inverseScreenValues is false (might rework * Test to fix pre MacOS 13.2 * Check this out * Using float instead of string * v2 * test * lets see * adding print * NSLog(@"macOS version: %f", [[PlaySettings shared] macOSVersion]); * [[PlaySettings shared] macOSVersion] rounded * adding 00000 to every float * testing * return back to normal double * Forgot about floating point error * more than 13.1 * more * 13.199 * setting to latest macOS version * more floating error and macOS fixes * reduced lines and fix some errors * Update project.pbxproj * Update project.pbxproj * Update PlaySettings.swift * Enables responsiveness for some apps for default screen settings if toggle enabled (PlayCover#5) * test disabling FBSDisplayMode * disabling FBS * Adding experimental fix toggle to fix responsiveness * adding an extra log * extra * moving the function to a better place * back to another place * added CheckResizabilityHasRun * Testing some stuff * name issue * added some comments to test * added fuction stop * True to yes * Changed yes to no * adding observer for resize * adding chess * test * back again * Removing extra check for a future commit * changed macos check to ios check * Remove macOSVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.