Skip to content

Conversation

TheMoonThatRises
Copy link
Member

Add settings for how Playcover uninstall apps. This includes removing keymapping, app settings, entitlements, and/or app containers. There is also an option to remove unused files and containers (unused as in the app is not installed).
Screenshot 2022-09-29 at 12 46 32

@amirsaam
Copy link
Member

Is it not better to have this options o the uninstall confirmation pop up?
This way users needs to open setting and change the setting everytime they want to delete an app but on the pop up they just need to check the options for that specific app.

@TheMoonThatRises
Copy link
Member Author

I could use both features, as the one in settings could as a default. The popup could be part of the confirm uninstall alert.

@Depal1
Copy link
Member

Depal1 commented Sep 29, 2022

You might want to take a look at this too #155.

@TheMoonThatRises
Copy link
Member Author

You might want to take a look at this too #155.

Do you want me to address it in this PR it a separate one?

@TheMoonThatRises
Copy link
Member Author

The uninstall popup currently looks like this.
uninstall_popup

@amirsaam
Copy link
Member

amirsaam commented Oct 4, 2022

is there a way to undo the Don't ask again option in PlayCover?
I think it's not necessary to have that now with this new options.
It's better to not have it than to have it

btw the strings should be simpler than the PlayCover Preferences like this:

  • Clear app data
  • Remove keymappings
  • Remove settings
  • Remove entitlements

@Depal1
Copy link
Member

Depal1 commented Oct 4, 2022

You might want to take a look at this too #155.

Do you want me to address it in this PR it a separate one?

If you want to address it, it could be better to implement it on a separate PR, unless it conflicts with your current implementation.

@TheMoonThatRises
Copy link
Member Author

is there a way to undo the Don't ask again option in PlayCover?

Yes, there's a way to undo not displaying the uninstall alert in settings.

the strings should be simpler than the PlayCover Preferences like this:

Done.

@amirsaam
Copy link
Member

amirsaam commented Oct 4, 2022

So if it undo it, can we have a note under it in small size (subtitle) to mention it?
Like You can change this in the PlayCover Preferences or smth like it.

@TheMoonThatRises
Copy link
Member Author

The suppression checkbox is an NSButton, so it can't have a subtitle. Would it be ok if the text was part of the title for the checkbox?

@amirsaam
Copy link
Member

amirsaam commented Oct 5, 2022

I'm afraid that it will not follow the guidelines but can we have a hoverable/clickkable U+1F6C8 (🛈) as part of the checkbox to show the message in a tooltip?

@TheMoonThatRises
Copy link
Member Author

Is this good?
uninstall_suppression_tooltip

@amirsaam
Copy link
Member

amirsaam commented Oct 5, 2022

Uhh, I can't figure out how it would be triggered?
Is it a pointer on text hover? If yes, it's hover trigger time should be => 0.5s

@TheMoonThatRises
Copy link
Member Author

The NSButton (which is what the suppression checkbox is made from) has a tooltip option. You would trigger it by hovering over the text.

@amirsaam
Copy link
Member

amirsaam commented Oct 5, 2022

I see. I think it will do the job. Thanks for being nice to do the extra work 👍

@TheMoonThatRises
Copy link
Member Author

Need to do more work on this PR since #398 is merged.

@Depal1 Depal1 added the squash Indicates whether a PR must be squashed before being merged label Oct 9, 2022
Copy link
Member

@Depal1 Depal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Featurewise this is working as intended. Prune is a nice touch.

@Depal1 Depal1 merged commit 2bd4366 into PlayCover:develop Oct 19, 2022
IsaacMarovitz added a commit to IsaacMarovitz/PlayCover that referenced this pull request Oct 20, 2022
* feat: app uninstall settings

* fix: localisation and lint

* add uninstall options to uninstall popup

* simplify uninstall message

* add suppression tooltip + simplify code

* clear all app cache in prune + simplify code

* simplify uninstall settings

Use KVC for settings variables

* simplify redundant texts
@TheMoonThatRises TheMoonThatRises deleted the feat/uninstallsettings branch January 1, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squash Indicates whether a PR must be squashed before being merged
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants