-
Notifications
You must be signed in to change notification settings - Fork 823
App uninstall settings #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App uninstall settings #383
Conversation
Is it not better to have this options o the uninstall confirmation pop up? |
I could use both features, as the one in settings could as a default. The popup could be part of the confirm uninstall alert. |
You might want to take a look at this too #155. |
Do you want me to address it in this PR it a separate one? |
is there a way to undo the btw the strings should be simpler than the PlayCover Preferences like this:
|
If you want to address it, it could be better to implement it on a separate PR, unless it conflicts with your current implementation. |
Yes, there's a way to undo not displaying the uninstall alert in settings.
Done. |
So if it undo it, can we have a note under it in small size (subtitle) to mention it? |
The suppression checkbox is an NSButton, so it can't have a subtitle. Would it be ok if the text was part of the title for the checkbox? |
I'm afraid that it will not follow the guidelines but can we have a hoverable/clickkable |
Uhh, I can't figure out how it would be triggered? |
The NSButton (which is what the suppression checkbox is made from) has a tooltip option. You would trigger it by hovering over the text. |
I see. I think it will do the job. Thanks for being nice to do the extra work 👍 |
Need to do more work on this PR since #398 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Featurewise this is working as intended. Prune is a nice touch.
* feat: app uninstall settings * fix: localisation and lint * add uninstall options to uninstall popup * simplify uninstall message * add suppression tooltip + simplify code * clear all app cache in prune + simplify code * simplify uninstall settings Use KVC for settings variables * simplify redundant texts
Add settings for how Playcover uninstall apps. This includes removing keymapping, app settings, entitlements, and/or app containers. There is also an option to remove unused files and containers (unused as in the app is not installed).
