Fix automatic screen size detection #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you set display mode Auto as the default behavior? |
I didn't change any default behavior |
|
I think it should default as auto since that is the ideal settings that will probably work for most users. |
|
one sec lemme fix the issues |
|
Alright the issues should be fixed now and i set the default |
Depal1
approved these changes
Sep 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous builds of PlayCover had an issue where the automatic screen size option would not use the correct aspect ratio (and apparently eventually became square?)
This fix sets the window size to the size of the full screen. If a notch is detected, it forces the aspect ratio to 16:10, which is the correct ratio of the screen size without the notch.