Code cleanup: removal of old resolution selector #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacMarovitz
approved these changes
Sep 9, 2022
IsaacMarovitz
approved these changes
Sep 11, 2022
JoseMoreville
approved these changes
Sep 13, 2022
|
@Depal1 What do you think on creating a deprecated folder to keep code to remove in future versions. so we keep a better track of it. |
|
I don’t think it is a good idea. Deprecated code will always be available for anyone interested on seeing it with version control, and easily accesible with tags, or even on a commit basis, as a core git feature. It is the recommended course of action as stated in git’s documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes files of the former resolution selector that was used prior to the merge of #290.