Skip to content

Conversation

ohaiibuzzle
Copy link
Member

This commit brings a new, guided approach for configuring app signing (which make login in apps like Genshin works)

The "wizard" guides the user through disabling SIP and disabling AMFI in a more visual manner.

Here is what it looks like:
Menu accessible via PlayCover > Configure Signing:
image

AMFI:
out

Signing ready:
image

@ZhichGaming
Copy link
Contributor

ZhichGaming commented Sep 8, 2022

Can you insert a button that links to the docs? Do the question marks point to their instructions as to how to set them?

@ohaiibuzzle
Copy link
Member Author

ohaiibuzzle commented Sep 8, 2022

Can you insert a button that links to the docs? Do the question marks point to their instructions as to how to set them?

Those buttons provides information as to why we are disabling those macOS features when you hover over them
Docs, we have one on the Help menu, do you think we need it here as well?

@amirsaam
Copy link
Member

amirsaam commented Sep 8, 2022

I think this gives a the user a feeling that he/she needs to do it once. more details i think is required under title.
like "you need to do this process everytime you want to login into a new account" or something like this.

@ZhichGaming
Copy link
Contributor

Can you insert a button that links to the docs? Do the question marks point to their instructions as to how to set them?

Those buttons provides information as to why we are disabling those macOS features when you hover over them Docs, we have one on the Help menu, do you think we need it here as well?

If It's only in the help menu, yes you should add a button linking to the docs maybe called "How to disable SIP and NVRAM" since people definitely would not know how to disable SIP without a guide and i would say most users do not know that we need to paste the nvram command in terminal.

@ZhichGaming
Copy link
Contributor

I think this gives a the user a feeling that he/she needs to do it once. more details i think is required under title. like "you need to do this process everytime you want to login into a new account" or something like this.

That is too Genshin specific, that pop up applies for a lot of apps.

@amirsaam
Copy link
Member

amirsaam commented Sep 8, 2022

I think this gives a the user a feeling that he/she needs to do it once. more details i think is required under title. like "you need to do this process everytime you want to login into a new account" or something like this.

That is too Genshin specific, that pop up applies for a lot of apps.

So, you don't have to disable sip everytime you want to login into a new account for a different app?

@ZhichGaming
Copy link
Contributor

I mean for some apps, you need SIP disabled the whole time not just for logging in.

@amirsaam
Copy link
Member

amirsaam commented Sep 8, 2022

So there could simply be a note like: "not every app let's you stay logged in after enabling sip again" or something like this

@ohaiibuzzle
Copy link
Member Author

I mean we can put up an abomination to modern design, ala. a wall of text, like so
image
if you are so worried about that

@amirsaam
Copy link
Member

amirsaam commented Sep 8, 2022

Lemme clarify, PlayCover dictionary is completely confusing. Words like PlayBook and PlayMap that currently are under use are not familiar to any user. I just saying we need to clarify not with a wall of words but with a couple of short notes.

Two note are necessary in my opinion that user should know:

  • Some apps may be logged out after enabling SIP afterwards.
  • If user wants to login into a new account, disabling SIP again is required.

@Depal1 Depal1 merged commit f3cdc84 into PlayCover:develop Sep 11, 2022
@ohaiibuzzle ohaiibuzzle deleted the feat/new-signing-experience branch September 16, 2022 07:30
IsaacMarovitz added a commit to IsaacMarovitz/PlayCover that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants