Skip to content

Fix no app icon for some app #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2022
Merged

Fix no app icon for some app #308

merged 2 commits into from
Sep 7, 2022

Conversation

KhoraLee
Copy link
Contributor

@KhoraLee KhoraLee commented Sep 6, 2022

This PR will extract app icon's also from Assets.car and select highest resolution icon.

Still apps that doesn't have app icon will show spinning progress circle.

@JoseMoreville JoseMoreville merged commit a97d9cd into PlayCover:develop Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacMarovitz IsaacMarovitz IsaacMarovitz approved these changes

@JoseMoreville JoseMoreville JoseMoreville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KhoraLee @IsaacMarovitz @JoseMoreville