Skip to content

Improve Xcode Command line tools install UX #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 30, 2022
Merged

Improve Xcode Command line tools install UX #250

merged 6 commits into from
Aug 30, 2022

Conversation

Candygoblen123
Copy link
Member

Improves Xcode command line tools detection by actually checking if the files are there, regardless of what xcode-select -p tells us

Improve the UI by:

  • Adding icons for preinstall, success, and failure steps
  • Playing a sound on successful and errored install
  • Provide a link to alternate install methods on failure
  • After install finishes, actually check to make sure that the Command Line tools were installed, and show the error screen if they aren't.

Screenshots:
Screen Shot 2022-08-26 at 10 15 42 AM
Screen Shot 2022-08-26 at 10 16 29 AM
Screen Shot 2022-08-26 at 10 17 20 AM
Screen Shot 2022-08-26 at 10 15 37 AM

@Depal1 Depal1 added the UI User interface related changes label Aug 27, 2022
Depal1
Depal1 requested changes Aug 29, 2022
View reviewed changes
Copy link
Member

@Depal1 Depal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are conflicts that need to be resolved before merging.

@Candygoblen123 Candygoblen123 requested a review from Depal1 August 29, 2022 16:08
@Depal1
Copy link
Member

Depal1 commented Aug 29, 2022

5c44924 is reverting changes from #258 and #262.

@Lakr233
Copy link

Lakr233 commented Aug 30, 2022

I have done similar design/stuff, could copy mine if you want :)

截屏2022-08-30 17 35 49

https://lab.qaq.wiki/Lakr233/ActionBee/-/blob/2d3e6b67866215c6ca6e088dae79ff73b12333aa/App/Action/Action/Interface/Generic/XcodeTestView.swift

@Candygoblen123
Merge branch '2.0-UI' of github.com:PlayCover/PlayCover into 2.0-UI
85adb98 
# Conflicts:
#	PlayCover/Utils/Shell.swift
#	PlayCover/Views/MainView.swift
#	PlayCover/en.lproj/Localizable.strings
@Candygoblen123
Fix merge errors
1d17e4d
@Depal1 Depal1 merged commit daa4715 into PlayCover:2.0-UI Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacMarovitz IsaacMarovitz IsaacMarovitz approved these changes

@Depal1 Depal1 Depal1 approved these changes

Assignees
No one assigned
Labels
UI User interface related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Candygoblen123 @Depal1 @Lakr233 @IsaacMarovitz