Skip to content

Fix all the stuff i didnt get done in 2.0.0 ui lol #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Aug 23, 2022
Merged

Fix all the stuff i didnt get done in 2.0.0 ui lol #232

merged 19 commits into from
Aug 23, 2022

Conversation

IsaacMarovitz
Copy link
Member

@IsaacMarovitz IsaacMarovitz commented Aug 22, 2022 •
edited
Loading

rainbows-cockroach
Fixing TODOs...
Very Serious Changelog:

  • Change app settings from a monolithic file to a per-app file stored in the Containers folder
  • Updated app settings to use a Codable struct for significantly better code readability
  • Fixed the appearance of AsyncImage and download icon from App Store for up-to-date icons and correct image size
  • Change keymapping so they are stored in the Containers folder and use Codable
  • Make 'reset settings' and 'reset keymapping' buttons functional
  • Finish localising strings

@IsaacMarovitz IsaacMarovitz changed the title App Settings Overhaul Fix all the stuff i didnt get done in 2.0.0 ui lol Aug 23, 2022
@Depal1
Copy link
Member

Depal1 commented Aug 23, 2022

Could you please list what UI parts are you addressing?

@Candygoblen123
Copy link
Member

rainbows-cockroach
Fixing TODOs...

please be professional in your PR descriptions

KhoraLee
KhoraLee reviewed Aug 23, 2022
View reviewed changes
KhoraLee
KhoraLee reviewed Aug 23, 2022
View reviewed changes
KhoraLee
KhoraLee reviewed Aug 23, 2022
View reviewed changes
KhoraLee
KhoraLee reviewed Aug 23, 2022
View reviewed changes
@IsaacMarovitz IsaacMarovitz marked this pull request as ready for review August 23, 2022 13:56
@IsaacMarovitz IsaacMarovitz marked this pull request as draft August 23, 2022 13:58
@IsaacMarovitz IsaacMarovitz marked this pull request as ready for review August 23, 2022 14:02
@Candygoblen123 Candygoblen123 merged commit 50f7066 into PlayCover:2.0-UI Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Depal1 Depal1 Depal1 left review comments

+2 more reviewers

@KhoraLee KhoraLee KhoraLee left review comments

@Candygoblen123 Candygoblen123 Candygoblen123 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
3.1.x - 3.2.0
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IsaacMarovitz @Depal1 @Candygoblen123 @KhoraLee