-
Notifications
You must be signed in to change notification settings - Fork 823
Fix Settings render issues #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Registrazione.schermo.2024-06-11.alle.23.20.54.mov |
Should be all, not totally sure if all settings is saved correctly. I checked MetalHUD and DiscordRP and both are correct |
Removed no necessary onChange()
I built this branch and all the controls I tested work properly. Clicking the "Fix window display issues" checkbox on the Graphics tab doesn't enable the dropdown next to it, but I've never used that, so I don't know how it's supposed to work. I can't seem to enable that dropdown in the old nightly 636, either. |
After looking through the code, I see that the dropdown only gets enabled when "Fix window display issues" is checked and "Resolution" is set to "App Default". It's working properly in this branch. 👍 |
I think we should wait for an update from Apple, as this is most likely a bug and not intended behaviour. This does not occur on previous versions. |
oh ok, btw this is a thing in other part of the project (Settings/InstallSettings.swift, PlayCover/Views/Settings/UpdateSettings.swift and PlayCover/Views/Settings/UninstallSettings.swift). |
I may be way off base here, but is the issue the multi-level object nesting? E.g., in the
All the docs and examples of SwiftUI data binding I've seen either use a directly published property, or use a property of a published class. I haven't seen anything which uses a property in a struct nested in a published class. |
I believe that this is the issue. @Catta1997 if you want to try fixing it by removing the nesting of classes and structures, do try. If not, I can merge this as a temporary fix. |
Ok, I will try |
But since I don know a lot SwiftUI I think you can merge this temporary fix 'cause I don't know if I will be able to fix it in the other way |
Start working on fix render issue of Settings UI where the toggle not update (state change but not graphically)