Skip to content

fix: Update account switcher UI #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2022
Merged

fix: Update account switcher UI #120

merged 3 commits into from
Jul 31, 2022

Conversation

Candygoblen123
Copy link
Member

  • require all fields to be filled out before the store button becomes available
  • add "Exit" button to store account sheet
  • switch from using pill-shaped buttons to using system-like buttons
  • add confirmation and warning when deleting an account
  • add confirmation and warning that restoring an account will override the currently signed-in account
  • fixed a force try crash when users tried to store an account without opening the game for the first time
  • removed various swiftlint:disable comments that didn't make much sense, and fixed the listing errors

@IsaacMarovitz IsaacMarovitz mentioned this pull request Jul 31, 2022
Merged
JoseMoreville
JoseMoreville approved these changes Jul 31, 2022
View reviewed changes
@JoseMoreville JoseMoreville merged commit 5ee1476 into PlayCover:develop Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseMoreville JoseMoreville JoseMoreville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Candygoblen123 @JoseMoreville