Skip to content

Fix environment variables when launching via alias #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2023
Merged

Fix environment variables when launching via alias #1090

merged 3 commits into from
Sep 25, 2023

Conversation

TheMoonThatRises
Copy link
Member

Sets the environmental variables in the Info.plist file inside the app. Fixes #1012.

Requires #1088 to be merged or modified into this pull request.

Thoughts for reviewer:

  • The app is required to be codesigned after each change to the Info.plist, which may be slow for larger apps.

@TheMoonThatRises TheMoonThatRises mentioned this pull request Sep 9, 2023
Merged
@TheMoonThatRises TheMoonThatRises force-pushed the fix/environment-variables branch from 914b2d0 to b3830de Compare September 9, 2023 19:37
@JoseMoreville JoseMoreville merged commit 6785597 into PlayCover:develop Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseMoreville JoseMoreville JoseMoreville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
3.1.x - 3.2.0
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Arknights - Crashes when opened from Dock/Launchpad
2 participants
@TheMoonThatRises @JoseMoreville