Skip to content

Conversation

ohaiibuzzle
Copy link
Member

This feature was suggested in issue #85

This gives the user an option to completely disable display sleep when a specific app is running. However, because of this, we had to change to using NSWorkspace.shared.openApplication to give PlayCover a handler to the running app and enable/disable display sleep accordingly, so this PR is may have unintended issues.

@Depal1 Depal1 requested a review from Candygoblen123 July 30, 2022 16:11
@ohaiibuzzle ohaiibuzzle force-pushed the feat/disable-timeout branch from 1825b70 to 35149a2 Compare July 31, 2022 05:15
@Depal1 Depal1 merged commit 219aeba into PlayCover:develop Jul 31, 2022
Depal1 pushed a commit that referenced this pull request Jul 31, 2022
* Replaced all strings with keys

Revamped the entire localizations with up-to-date sentences written with the current situation in mind

* Wiped all previous translations

Lots of old translations no longer apply, and it is a good idea to get people to translate for the app again according to the current situation now that the base localization (English) is accurate and up-to-date

* Tuned code for proper building

Fixed some issues with the locale files

* Attempting to resolve conflict

ignore this 💀

* Reverted whatever I just did

* ;-; forgot to stage a file

* Reverted unintentional changes to code

Reverted button style, brought back "soundAlert.*"

* Salvaged some german locales

* Restored french translation of sound alert

* Tuned some UI aspect of things

Adjusted minimum window size for fitting to 4 columns of apps just right, fixed a typo that exposed raw string key, and added some horizontal paddings to search bar for better aesthetics

Modded various UI aspect of things

used same style as every other buttons in UI for consistency

Trimmed paddings on bottom bar

Adjusted padding for even paddings around buttons (because there is an un-removable safe area padding at the bottom of the window (which i cant seem to nuke by "ignoreSafeArea()") )

Added a thin border to search bar

for aesthetic purposes and ease of use by creating that contrast between search bar and background

* Added Chinese locales

:chef_kiss:

Updated my Chinese locale

updated to the new formatting used

* Ironed out locales formatting

Added spacings to separate different types of messages and changed some keys for consistency

Tuned ".ipa" parts for consistency

Updated text in setup view

* Repositioned crash button

moved crash button to the left of "Experiencing issues?" button to save some space and avoid taking up unnecessary row of space just for the 1 button

* Remove unnecessary imports

SwiftUI is all we need ✨

* Making changes according to isaac

* Changed grammar errors and cleaned code

According to Isaac's comments

* Modded upstream code to match current changes

* Updated locale to work with #108

Added and mapped keys to strings

Updated more UI to work with locale

Reverted signing settings

Reverted changes

Updated locale

* Removed unnecessary @State attribute

* Removed "private" attrib for code building

* Changed locale based on suggestions

* Reverted UI changes

mainly the bottom two buttons in swttings view

* Updated locale to work with latest PR

* Changed locale based on suggestions

Updated locale to work with latest PR

* Reverted UI changes

mainly the bottom two buttons in swttings view

* ignore project.pbxproj

* Revert "ignore project.pbxproj"

This reverts commit de00985.

Reverted ignore settings

* Reverted UI change suggested by Depal

* Reverted more UI suggested by Isaac

Added corner radius

* Reverted UI from Isaac's comments

Fixed some changes

* Revert "Remove unnecessary imports"

This reverts commit 686d1a7.

* Addes keys to AppView.swift

* Update locale for #95

* Updated keys to work with locale

SetupView.swift
@ohaiibuzzle ohaiibuzzle deleted the feat/disable-timeout branch August 2, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants