Revamped localization system (much more accurate and up to date) #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revamped the entire localizations with up-to-date sentences written with the current situation in mind
Lots of old translations no longer apply, and it is a good idea to get people to translate for the app again according to the current situation now that the base localization (English) is accurate and up-to-date
Fixed some issues with the locale files
ignore this 💀
# Conflicts: # PlayCover/ViewModel/Log.swift # PlayCover/de.lproj/Localizable.strings # PlayCover/en.lproj/Localizable.strings # PlayCover/es.lproj/Localizable.strings # PlayCover/fr.lproj/Localizable.strings # PlayCover/id.lproj/Localizable.strings # PlayCover/it.lproj/Localizable.strings # PlayCover/ja.lproj/Localizable.strings # PlayCover/ko.lproj/Localizable.strings # PlayCover/ru.lproj/Localizable.strings # PlayCover/vi.lproj/Localizable.strings # PlayCover/zh-Hans.lproj/Localizable.strings
# Conflicts: # PlayCover/View/AppSettingsView.swift
# Conflicts: # PlayCover/View/AppSettingsView.swift # PlayCover/ViewModel/Log.swift
# Conflicts: # PlayCover/View/AppsView.swift
IsaacMarovitz
requested changes
Jul 24, 2022
Reverted button style, brought back "soundAlert.*"
… feature/revamped-string-keys
IsaacMarovitz
requested changes
Jul 26, 2022
Adjusted minimum window size for fitting to 4 columns of apps just right, fixed a typo that exposed raw string key, and added some horizontal paddings to search bar for better aesthetics Modded various UI aspect of things used same style as every other buttons in UI for consistency Trimmed paddings on bottom bar Adjusted padding for even paddings around buttons (because there is an un-removable safe area padding at the bottom of the window (which i cant seem to nuke by "ignoreSafeArea()") ) Added a thin border to search bar for aesthetic purposes and ease of use by creating that contrast between search bar and background
:chef_kiss: Updated my Chinese locale updated to the new formatting used
Added spacings to separate different types of messages and changed some keys for consistency Tuned ".ipa" parts for consistency Updated text in setup view
moved crash button to the left of "Experiencing issues?" button to save some space and avoid taking up unnecessary row of space just for the 1 button
SwiftUI is all we need ✨
… feature/revamped-string-keys
IsaacMarovitz
approved these changes
Jul 30, 2022
|
There are conflicts on this PR, a rebase is required. |
Depal1
reviewed
Jul 30, 2022
Depal1
requested changes
Jul 30, 2022
… feature/revamped-string-keys # Conflicts: # PlayCover/View/AppsView.swift
IsaacMarovitz
requested changes
Jul 31, 2022
This reverts commit de00985. Reverted ignore settings
IsaacMarovitz
requested changes
Jul 31, 2022
IsaacMarovitz
requested changes
Jul 31, 2022
|
I think that's the last remaining UI change. Will need to be rebased and expanded when #120 gets merged. |
Added corner radius
… feature/revamped-string-keys # Conflicts: # PlayCover/View/ChangeGenshinAccountView.swift # PlayCover/View/DeleteGenshinStoredAccountView.swift # PlayCover/View/PlayAppView.swift # PlayCover/View/StoreGenshinAccountView.swift
Fixed some changes
This reverts commit 686d1a7.
Depal1
approved these changes
Jul 31, 2022
This was referenced Jul 31, 2022
This was referenced Jul 31, 2022
Depal1
pushed a commit
that referenced
this pull request
Jul 31, 2022
* Replaced all strings with keys Revamped the entire localizations with up-to-date sentences written with the current situation in mind * Wiped all previous translations Lots of old translations no longer apply, and it is a good idea to get people to translate for the app again according to the current situation now that the base localization (English) is accurate and up-to-date * Tuned code for proper building Fixed some issues with the locale files * Attempting to resolve conflict ignore this 💀 * Reverted whatever I just did * ;-; forgot to stage a file * Reverted unintentional changes to code Reverted button style, brought back "soundAlert.*" * Salvaged some german locales * Restored french translation of sound alert * Tuned some UI aspect of things Adjusted minimum window size for fitting to 4 columns of apps just right, fixed a typo that exposed raw string key, and added some horizontal paddings to search bar for better aesthetics Modded various UI aspect of things used same style as every other buttons in UI for consistency Trimmed paddings on bottom bar Adjusted padding for even paddings around buttons (because there is an un-removable safe area padding at the bottom of the window (which i cant seem to nuke by "ignoreSafeArea()") ) Added a thin border to search bar for aesthetic purposes and ease of use by creating that contrast between search bar and background * Added Chinese locales :chef_kiss: Updated my Chinese locale updated to the new formatting used * Ironed out locales formatting Added spacings to separate different types of messages and changed some keys for consistency Tuned ".ipa" parts for consistency Updated text in setup view * Repositioned crash button moved crash button to the left of "Experiencing issues?" button to save some space and avoid taking up unnecessary row of space just for the 1 button * Remove unnecessary imports SwiftUI is all we need ✨ * Making changes according to isaac * Changed grammar errors and cleaned code According to Isaac's comments * Modded upstream code to match current changes * Updated locale to work with #108 Added and mapped keys to strings Updated more UI to work with locale Reverted signing settings Reverted changes Updated locale * Removed unnecessary @State attribute * Removed "private" attrib for code building * Changed locale based on suggestions * Reverted UI changes mainly the bottom two buttons in swttings view * Updated locale to work with latest PR * Changed locale based on suggestions Updated locale to work with latest PR * Reverted UI changes mainly the bottom two buttons in swttings view * ignore project.pbxproj * Revert "ignore project.pbxproj" This reverts commit de00985. Reverted ignore settings * Reverted UI change suggested by Depal * Reverted more UI suggested by Isaac Added corner radius * Reverted UI from Isaac's comments Fixed some changes * Revert "Remove unnecessary imports" This reverts commit 686d1a7. * Addes keys to AppView.swift * Update locale for #95 * Updated keys to work with locale SetupView.swift
ZhichGaming
added a commit
to ZhichGaming/PlayCover
that referenced
this pull request
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated UI with more accurate and up-to-date sentences for much better clarity
Wiped all translations since most are outdated and irrelevant in the current code and it is a good idea to get everything translated again (a good chance for more people to contribute)
with the new key system for strings, it is now much more easier to manage them and not worrying about typos for synchronisation between source code and locale files
A continuation from PR #84 due to some ridiculous code merging that caused my previous work to go kaboom 💀