xclt less installer macho converter code cleanup #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good, thank you for the cleanup! Gonna test the full suite of apps now just to make sure nothing went wrong. |
IsaacMarovitz
added a commit
to IsaacMarovitz/PlayCover
that referenced
this pull request
Mar 11, 2023
* macho converter code cleanup * lint lc iterate in playtools * add back enough space check * Update Macho.swift * Add Macho.swift to project * Indentation adjustments --------- Co-authored-by: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com> Co-authored-by: Isaac Marovitz <isaacryu@icloud.com>
IsaacMarovitz
added a commit
to IsaacMarovitz/PlayCover
that referenced
this pull request
Mar 11, 2023
* macho converter code cleanup * lint lc iterate in playtools * add back enough space check * Update Macho.swift * Add Macho.swift to project * Indentation adjustments --------- Co-authored-by: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com> Co-authored-by: Isaac Marovitz <isaacryu@icloud.com>
JoseMoreville
pushed a commit
that referenced
this pull request
Mar 16, 2023
* Fix XCLT-less Installer (#830) * Revert "Add `install_name_tool` replacement (#794)" This reverts commit 9590e8d. * Comment the theory * Yipee * SwiftLint * Step 4 * SwiftLint * Fix cast whoopsie * Fixes * Some fixes and cleanup * Spacing * It works * SwiftLint * Change path * Cleanup version command replacement * More optimisations * Fix strip * Add more prints * More cleanup * Cleanup and simplify * SwiftLint * Adjust prints * SwiftLint :/ * More info * Start XCLT-like insert replace (almost working) * Revert "Start XCLT-like insert replace (almost working)" This reverts commit d35772b. * XCLT-like path replacement * Fix padding * Fix space check * Xyct suggestion not sure if this is necessary * Who needs error checking anyways * Fix PT failing to install first time in FAT binaries * xclt less installer macho converter code cleanup (#851) * macho converter code cleanup * lint lc iterate in playtools * add back enough space check * Update Macho.swift * Add Macho.swift to project * Indentation adjustments --------- Co-authored-by: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com> Co-authored-by: Isaac Marovitz <isaacryu@icloud.com> --------- Co-authored-by: Xyct <87l46110@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new file
Macho.swiftto put macho-related code, so thatPlayToolshas less lines thanswiftlint's upper boundAdded sanity checks while iterating load commands.
Added byte order checks while replacing load commands.
Variable names changed to more meaningful ones.