feat!: KeyCover keychain encryption for PlayChain #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4efbbb8 to
19931ce
Compare
3e1a072 to
818fc54
Compare
ab56db4 to
a89d756
Compare
…e term "bruh" which is not considered inclusive (inclusive_language)
IsaacMarovitz
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a new set of feature for PlayCover called KeyCover that works in tandom with the previously introduced PlayChain
Since PlayChain stores keys as-is, an actor from macOS or an app installed in PlayCover can simply dump the chain of every PlayChain-enabled apps.
KeyCover mitigates this issue by encrypting the keys using AES-256-CBC with a key that is either set by the user or automatically generated and saved in Apple Keychain
Also includes some performance-related changes to PlayCover (eg. making app launch asynchronous)