Fix: Stop splash screen appearing unnecessarily #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
App Library splash screen appeared if a search argument yields no results.
IsaacMarovitz
requested changes
Jan 29, 2023
Changed variable names: apps -> filteredApps unfilteredApps -> apps
IsaacMarovitz
requested changes
Jan 29, 2023
These include: - Unnecessary clearing apps array - Not supposed to use filteredList
IsaacMarovitz
approved these changes
Jan 29, 2023
IsaacMarovitz
pushed a commit
to IsaacMarovitz/PlayCover
that referenced
this pull request
Mar 11, 2023
* Fix: Stop splash screen appearing unnecessarily App Library splash screen appeared if a search argument yields no results. * Chore: Rename appsVM variables Changed variable names: apps -> filteredApps unfilteredApps -> apps * Chore: Isaac’s nitpicks These include: - Unnecessary clearing apps array - Not supposed to use filteredList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App Library splash screen appeared if a search argument yields no results.