Skip to content

Add force_unwrapping rule to SwiftLint #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 11, 2023
Merged

Add force_unwrapping rule to SwiftLint #753

merged 14 commits into from
Mar 11, 2023

Conversation

IsaacMarovitz
Copy link
Member

@IsaacMarovitz IsaacMarovitz commented Jan 29, 2023 •
edited
Loading

  • Removes all force unwraps (except for a few in PlayTools and other places)
  • Adds the force_unwrapping rule to SwiftLint
  • Removes disabling of inclusive_language rule from SwiftLint
  • Removes UIF
  • Refactors Shell

@IsaacMarovitz IsaacMarovitz marked this pull request as ready for review January 29, 2023 00:35
@TheMoonThatRises TheMoonThatRises added the squash Indicates whether a PR must be squashed before being merged label Jan 31, 2023
@IsaacMarovitz IsaacMarovitz requested a review from Depal1 January 31, 2023 18:52
@IsaacMarovitz IsaacMarovitz marked this pull request as draft February 3, 2023 13:51
@IsaacMarovitz IsaacMarovitz marked this pull request as ready for review February 3, 2023 14:23
@IsaacMarovitz IsaacMarovitz requested review from Depal1 and JoseMoreville and removed request for Depal1 February 23, 2023 14:50
JoseMoreville
JoseMoreville reviewed Mar 10, 2023
View reviewed changes
Copy link
Member

@JoseMoreville JoseMoreville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far it looks good, great job isaac. just a few reviews

@IsaacMarovitz IsaacMarovitz marked this pull request as draft March 11, 2023 02:56
@IsaacMarovitz IsaacMarovitz marked this pull request as ready for review March 11, 2023 15:02
@IsaacMarovitz IsaacMarovitz merged commit df96821 into PlayCover:develop Mar 11, 2023
@IsaacMarovitz IsaacMarovitz deleted the force-unwrap branch March 11, 2023 15:03
IsaacMarovitz added a commit to IsaacMarovitz/PlayCover that referenced this pull request Mar 11, 2023
@IsaacMarovitz
Add force_unwrapping rule to SwiftLint (PlayCover#753)
337a6b7 
* Remove force unwraps

* Remove UIF

* Fixes

* Merge fixes

* SwiftLint

* Fixes

* Fix errors

* Fix typo

* Remove unnecessary function

* Cleanup shell

Still got a couple things to fix up

* Fix lldb

* Fix put IPA back
IsaacMarovitz added a commit to IsaacMarovitz/PlayCover that referenced this pull request Mar 11, 2023
@IsaacMarovitz
Fix conflicts
54c31f1 
commit 7e9357a
Author: Weblate (bot) <hosted@weblate.org>
Date:   Sat Mar 11 16:12:45 2023 +0100

    Translations update from Hosted Weblate (PlayCover#847)

    * Translated using Weblate (Russian)

    Currently translated at 84.2% (198 of 235 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ru/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Indonesian)

    Currently translated at 68.9% (162 of 235 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/id/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Japanese)

    Currently translated at 92.3% (217 of 235 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ja/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Korean)

    Currently translated at 86.3% (203 of 235 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ko/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Persian)

    Currently translated at 86.3% (203 of 235 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/fa/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Romanian)

    Currently translated at 68.9% (162 of 235 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ro/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Danish)

    Currently translated at 45.1% (106 of 235 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/da/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Chinese (Traditional))

    Currently translated at 99.1% (233 of 235 strings)

    Translated using Weblate (Chinese (Traditional))

    Currently translated at 97.0% (228 of 235 strings)

    Update translation files

    Updated by "Cleanup translation files" hook in Weblate.

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Co-authored-by: rootmelo92118 <rootmelo92118@gmail.com>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/zh_Hant/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Turkish)

    Currently translated at 87.2% (205 of 235 strings)

    Update translation files

    Updated by "Cleanup translation files" hook in Weblate.

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/tr/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Hindi)

    Currently translated at 85.1% (200 of 235 strings)

    Update translation files

    Updated by "Cleanup translation files" hook in Weblate.

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/hi/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Portuguese (Brazil))

    Currently translated at 97.0% (228 of 235 strings)

    Update translation files

    Updated by "Cleanup translation files" hook in Weblate.

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/pt_BR/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Spanish)

    Currently translated at 100.0% (235 of 235 strings)

    Translated using Weblate (Spanish)

    Currently translated at 97.0% (228 of 235 strings)

    Update translation files

    Updated by "Cleanup translation files" hook in Weblate.

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Co-authored-by: gallegonovato <fran-carro@hotmail.es>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/es/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (German)

    Currently translated at 100.0% (235 of 235 strings)

    Translated using Weblate (German)

    Currently translated at 97.0% (228 of 235 strings)

    Update translation files

    Updated by "Cleanup translation files" hook in Weblate.

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Co-authored-by: SkyrilHD <skyrilhd@gmail.com>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/de/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Vietnamese)

    Currently translated at 93.6% (220 of 235 strings)

    Update translation files

    Updated by "Cleanup translation files" hook in Weblate.

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/vi/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Chinese (Simplified))

    Currently translated at 100.0% (235 of 235 strings)

    Translated using Weblate (Chinese (Simplified))

    Currently translated at 99.1% (233 of 235 strings)

    Translated using Weblate (Chinese (Simplified))

    Currently translated at 98.7% (232 of 235 strings)

    Translated using Weblate (Chinese (Simplified))

    Currently translated at 100.0% (232 of 232 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Co-authored-by: rootmelo92118 <rootmelo92118@gmail.com>
    Co-authored-by: weng weng <carlchina@gmail.com>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/zh_Hans/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (French)

    Currently translated at 93.6% (220 of 235 strings)

    Update translation files

    Updated by "Cleanup translation files" hook in Weblate.

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/fr/
    Translation: PlayCover/PlayCover

    ---------

    Co-authored-by: rootmelo92118 <rootmelo92118@gmail.com>
    Co-authored-by: gallegonovato <fran-carro@hotmail.es>
    Co-authored-by: SkyrilHD <skyrilhd@gmail.com>
    Co-authored-by: weng weng <carlchina@gmail.com>

commit c49f1fc
Author: OHaiiBuzzle <23693150+ohaiibuzzle@users.noreply.github.com>
Date:   Sat Mar 11 22:11:08 2023 +0700

    feat: starts app asynchronously (PlayCover#856)

    * feat: starts app asynchronously

    * fix: add a lock to app startup to prevent starting the same app twice

commit df96821
Author: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com>
Date:   Sat Mar 11 15:03:40 2023 +0000

    Add `force_unwrapping` rule to SwiftLint (PlayCover#753)

    * Remove force unwraps

    * Remove UIF

    * Fixes

    * Merge fixes

    * SwiftLint

    * Fixes

    * Fix errors

    * Fix typo

    * Remove unnecessary function

    * Cleanup shell

    Still got a couple things to fix up

    * Fix lldb

    * Fix put IPA back

commit c42cc67
Author: Weblate (bot) <hosted@weblate.org>
Date:   Tue Mar 7 16:44:50 2023 +0100

    Translations update from Hosted Weblate (PlayCover#844)

    * Translated using Weblate (Russian)

    Currently translated at 85.3% (198 of 232 strings)

    Update translation files

    Updated by "Cleanup translation files" hook in Weblate.

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ru/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Indonesian)

    Currently translated at 69.8% (162 of 232 strings)

    Update translation files

    Updated by "Cleanup translation files" hook in Weblate.

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/id/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Japanese)

    Currently translated at 93.5% (217 of 232 strings)

    Update translation files

    Updated by "Cleanup translation files" hook in Weblate.

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ja/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Korean)

    Currently translated at 87.5% (203 of 232 strings)

    Update translation files

    Updated by "Cleanup translation files" hook in Weblate.

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ko/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Persian)

    Currently translated at 87.5% (203 of 232 strings)

    Update translation files

    Updated by "Cleanup translation files" hook in Weblate.

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/fa/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Romanian)

    Currently translated at 69.8% (162 of 232 strings)

    Update translation files

    Updated by "Cleanup translation files" hook in Weblate.

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ro/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Danish)

    Currently translated at 45.6% (106 of 232 strings)

    Translated using Weblate (Danish)

    Currently translated at 0.0% (0 of 232 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Bastian Inuk Christensen <bastian@inuk.blog>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/da/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Chinese (Traditional))

    Currently translated at 98.2% (228 of 232 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/zh_Hant/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Turkish)

    Currently translated at 88.3% (205 of 232 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/tr/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Hindi)

    Currently translated at 86.2% (200 of 232 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/hi/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Portuguese (Brazil))

    Currently translated at 98.2% (228 of 232 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/pt_BR/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Spanish)

    Currently translated at 98.2% (228 of 232 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/es/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (German)

    Currently translated at 98.2% (228 of 232 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/de/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Vietnamese)

    Currently translated at 94.8% (220 of 232 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/vi/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (Chinese (Simplified))

    Currently translated at 98.2% (228 of 232 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/zh_Hans/
    Translation: PlayCover/PlayCover

    * Translated using Weblate (French)

    Currently translated at 94.8% (220 of 232 strings)

    Co-authored-by: Anonymous <noreply@weblate.org>
    Co-authored-by: Hosted Weblate <hosted@weblate.org>
    Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/fr/
    Translation: PlayCover/PlayCover

    ---------

    Co-authored-by: Bastian Inuk Christensen <bastian@inuk.blog>

commit 70dafc0
Author: TheMoonThatRises <58153205+TheMoonThatRises@users.noreply.github.com>
Date:   Tue Mar 7 00:06:22 2023 -0700

    HTTP code check (PlayCover#839)

    * feat: IPA library http code check

    * feat: less laggy IPA library loading images

    * fix swiftlint

commit b6a60c8
Author: OHaiiBuzzle <23693150+ohaiibuzzle@users.noreply.github.com>
Date:   Tue Mar 7 13:50:38 2023 +0700

    feat: allow injection of introspection libraries (fix some apps) (PlayCover#846)

commit 6d0b873
Author: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com>
Date:   Mon Mar 6 15:07:27 2023 +0000

    Remove Catalan, add Danish (PlayCover#843)

commit eca78b7
Author: OHaiiBuzzle <23693150+ohaiibuzzle@users.noreply.github.com>
Date:   Mon Mar 6 22:06:57 2023 +0700

    feat: adding an alternate window fix mode for apps that are able to handle display by themselves (PlayCover#842)

commit 9240be7
Author: Depal1 <47154119+Depal1@users.noreply.github.com>
Date:   Sat Mar 4 08:47:45 2023 -0600

    revert alphabetic sort in IPA Library

    IPA Library alphabetic sort is reverted, until an user defined sorting scheme is introduced later.

commit 9888c2c
Author: Depal1 <47154119+Depal1@users.noreply.github.com>
Date:   Sat Mar 4 08:39:41 2023 -0600

    Review (PlayCover#803) Spanish strings

    Review of Spanish localizations introduced in https://github.com/PlayCover/PlayCover/pull/803/files#diff-1e0ed8a0a66db1bc3fffc7012feaaec1a269306487272a9ada72e941d0b2ea82.
@TheMoonThatRises TheMoonThatRises mentioned this pull request May 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseMoreville JoseMoreville JoseMoreville approved these changes

@Depal1 Depal1 Awaiting requested review from Depal1

Assignees
No one assigned
Labels
squash Indicates whether a PR must be squashed before being merged
Projects
3.1.x - 3.2.0
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IsaacMarovitz @JoseMoreville @TheMoonThatRises