Skip to content

3.0.0 Cleanup #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jan 28, 2023
Merged

3.0.0 Cleanup #743

merged 19 commits into from
Jan 28, 2023

Conversation

IsaacMarovitz
Copy link
Member

@IsaacMarovitz IsaacMarovitz commented Jan 23, 2023 •
edited
Loading

  • Correct capitalisation of kHz
  • Bump version number to 3.0.0 (to make sparkle shut up on nightlies)
  • Enable PlayChain by default
  • Reorder Misc/Bypasses
  • Remove dead code

@TheMoonThatRises TheMoonThatRises added the squash Indicates whether a PR must be squashed before being merged label Jan 23, 2023
@IsaacMarovitz IsaacMarovitz marked this pull request as ready for review January 23, 2023 23:44
@IsaacMarovitz IsaacMarovitz requested a review from Depal1 January 24, 2023 01:58
@Depal1 Depal1 merged commit 3ace3b0 into PlayCover:develop Jan 28, 2023
@IsaacMarovitz IsaacMarovitz deleted the 3.0-cleanup branch January 29, 2023 00:41
IsaacMarovitz added a commit to IsaacMarovitz/PlayCover that referenced this pull request Mar 11, 2023
@IsaacMarovitz @Depal1
3.0.0 Cleanup (PlayCover#743)
ec9816d 
* Bump build number

* Remove Genshin Account Switcher

* Remove SigningSetupView

* Enable PlayChain by default

* Move PlayChain to Bypasses tab

* Fix locale

* Revert "Remove Genshin Account Switcher"

This reverts commit 407e1d4.

# Conflicts:
#	PlayCover.xcodeproj/project.pbxproj

* Fix project.pbxproj

* Remove scripts folder

* Cleanup + remove dead code

* Revert "Remove SigningSetupView"

This reverts commit 0bea329.

# Conflicts:
#	PlayCover.xcodeproj/project.pbxproj
#	PlayCover/en.lproj/Localizable.strings

* Fix project.pbxproj

* SwiftLint

* Make PlayTools quieter

* Make `fetchApps()` quieter

* Fix a typo

* Remove file thats been living rent free

* Remove more unused files

* Revert "Make `fetchApps()` quieter"

This reverts commit bfa9fa8.

---------

Co-authored-by: Depal1 <47154119+Depal1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Depal1 Depal1 Depal1 approved these changes

Assignees
No one assigned
Labels
squash Indicates whether a PR must be squashed before being merged
Projects
3.1.x - 3.2.0
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IsaacMarovitz @Depal1 @TheMoonThatRises