Skip to content

Conversation

IsaacMarovitz
Copy link
Member

@IsaacMarovitz IsaacMarovitz commented Jan 17, 2023

Change:

  • Replaces all uses of Xcode CLI with our own implementations, based on inject
  • Installing Xcode CLI would no longer be required after this PR

install_name_tool usage not converted cause it's not necessary afaik

I will leave removing the UI and backend surrounding Xcode CLI to another PR so that the changes from this one can easily be tested in isolation.

@Depal1 Depal1 added the squash Indicates whether a PR must be squashed before being merged label Jan 17, 2023
@IsaacMarovitz
Copy link
Member Author

IsaacMarovitz commented Jan 18, 2023

Needs further testing but heres a list of apps I've tried (all have worked):

  • Genshin Impact (big, modern)
  • Terraria (modern, fat)
  • Payback2 (fat)
  • Temple Run (old)
  • Plants v.s. Zombies (old)
  • Snapchat (modern)

@IsaacMarovitz IsaacMarovitz requested a review from Depal1 January 18, 2023 19:58
@IsaacMarovitz
Copy link
Member Author

i've tested all the apps in the example source

  • Moon

@IsaacMarovitz
Copy link
Member Author

download

@Depal1 Depal1 merged commit 089fc46 into PlayCover:develop Jan 21, 2023
@IsaacMarovitz IsaacMarovitz deleted the xcode-cli branch January 21, 2023 19:44
Depal1 added a commit to Depal1/PlayCover that referenced this pull request Feb 14, 2023
Depal1 added a commit to Depal1/PlayCover that referenced this pull request Feb 28, 2023
Depal1 added a commit that referenced this pull request Mar 1, 2023
* Revert "Add `install_name_tool` replacement (#794)"

This reverts commit 9590e8d.

* Revert "Remove Xcode CLI UI"

This reverts commit 19a3948.

* Revert "Remove Xcode CLI Dependancy (#711)"

This reverts commit 089fc46.

* Delete DataExtensions.swift

* Update project.pbxproj

* Fix project references
IsaacMarovitz added a commit to IsaacMarovitz/PlayCover that referenced this pull request Mar 11, 2023
* Remove otool usage

* Start tossing out `vtool` (Not working :( rn )

* Remove use of `lipo`

* Remove replaceLibraries

* Error checking

* SwiftLint

* Endianness fixes

* Ignore file_length

* Remove debug prints

* Make functions shorter

* SwiftLint

* Fix `isMachoEncrypted`

* Fix `isMachoValidArch`

* Very very broken rn

* Fix some things + better logs

* Fix properly

* 3rd times the charm

* 4th times the charm

* SwiftLint

* Add todo

* SHE WORKS CAP’IN

* TODO

* Remove vtool :basil_wave:

* SwiftLint

* Make vars constant

* Restructure Extensions

* strip for PlayTools install check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squash Indicates whether a PR must be squashed before being merged
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants