-
Notifications
You must be signed in to change notification settings - Fork 824
Remove Xcode CLI Dependancy #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 18, 2023
Needs further testing but heres a list of apps I've tried (all have worked):
|
|
TheMoonThatRises
approved these changes
Jan 18, 2023
f4926e1
to
579657e
Compare
Depal1
approved these changes
Jan 21, 2023
Depal1
added a commit
to Depal1/PlayCover
that referenced
this pull request
Feb 14, 2023
This reverts commit 089fc46.
Depal1
added a commit
to Depal1/PlayCover
that referenced
this pull request
Feb 28, 2023
This reverts commit 089fc46.
IsaacMarovitz
added a commit
to IsaacMarovitz/PlayCover
that referenced
this pull request
Mar 11, 2023
* Remove otool usage * Start tossing out `vtool` (Not working :( rn ) * Remove use of `lipo` * Remove replaceLibraries * Error checking * SwiftLint * Endianness fixes * Ignore file_length * Remove debug prints * Make functions shorter * SwiftLint * Fix `isMachoEncrypted` * Fix `isMachoValidArch` * Very very broken rn * Fix some things + better logs * Fix properly * 3rd times the charm * 4th times the charm * SwiftLint * Add todo * SHE WORKS CAP’IN * TODO * Remove vtool :basil_wave: * SwiftLint * Make vars constant * Restructure Extensions * strip for PlayTools install check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
inject
install_name_tool
usage not converted cause it's not necessary afaikI will leave removing the UI and backend surrounding Xcode CLI to another PR so that the changes from this one can easily be tested in isolation.