New Cache System #624
Merged
New Cache System #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
IsaacMarovitz
requested changes
Dec 28, 2022
IsaacMarovitz
approved these changes
Dec 28, 2022
KhoraLee
suggested changes
Dec 29, 2022
Depal1
approved these changes
Dec 29, 2022
IsaacMarovitz
pushed a commit
to IsaacMarovitz/PlayCover
that referenced
this pull request
Mar 11, 2023
* New Cache System * Update README.md * Update Localizable.strings * Update Cacher.swift * Update MenuBarView.swift * load time fix * code cleanup * Resolving Reviews * I pushed Code Signings again :iaminpain:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cacherclass has been introduced inCacher.swiftthat usesDataCachepackageImageCacheclass and rewrote the logic and reworked all usages of itgetITunesDatafunction so any part of PlayCover can use it as a function as it should not be in a class that is unrelated to its functionalityImageCachebug)