Skip to content

Conversation

amirsaam
Copy link
Member

@amirsaam amirsaam commented Dec 24, 2022

A new DownloadApp class has been introduced into PlayCover.
Able to cancel downloads, retries download as how many time you config it to do (default is 3)

Note: The DownloadManager package can handle multiple downloads at the same time and cancel each one of them if user wants but I avoided to implement that into PlayCover for multiple reasons like Installer.

DownloadApp class usage example:

if downloadVM.downloading {
    DownloadApp(url: nil, app: nil, warning: nil).cancel()
} else {
    DownloadApp(url: DownloadURL, app: StoreAppDataObject, warning: VersionCompareWarning).start()
}

@amirsaam amirsaam changed the title New Downloader Class Better Download Handler (Class) Dec 24, 2022
Added back 2click to DL (Tweaked)
ToastView Cancel DL Button
Downloader Class Optional `init` to handle cancel downloads from anywhere
@IsaacMarovitz IsaacMarovitz requested a review from Depal1 December 28, 2022 20:36
@Depal1 Depal1 merged commit 4697975 into PlayCover:develop Dec 29, 2022
@amirsaam amirsaam deleted the New-Downloader branch December 29, 2022 20:39
IsaacMarovitz pushed a commit to IsaacMarovitz/PlayCover that referenced this pull request Mar 11, 2023
* New Downloader Class

* Change to FileManager API

* Resolving Reviews

Added back 2click to DL (Tweaked)
ToastView Cancel DL Button
Downloader Class Optional `init` to handle cancel downloads from anywhere

* As Isaac said 👽

* preventing possible multiple downloads

* isaac gives this old man hard time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants