-
Notifications
You must be signed in to change notification settings - Fork 823
Better Download Handler (Class) #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 24, 2022
Merged
1 task
IsaacMarovitz
requested changes
Dec 28, 2022
Added back 2click to DL (Tweaked) ToastView Cancel DL Button Downloader Class Optional `init` to handle cancel downloads from anywhere
IsaacMarovitz
approved these changes
Dec 28, 2022
Depal1
approved these changes
Dec 29, 2022
IsaacMarovitz
pushed a commit
to IsaacMarovitz/PlayCover
that referenced
this pull request
Mar 11, 2023
* New Downloader Class * Change to FileManager API * Resolving Reviews Added back 2click to DL (Tweaked) ToastView Cancel DL Button Downloader Class Optional `init` to handle cancel downloads from anywhere * As Isaac said 👽 * preventing possible multiple downloads * isaac gives this old man hard time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new DownloadApp class has been introduced into PlayCover.
Able to cancel downloads, retries download as how many time you config it to do (default is 3)
Note: The DownloadManager package can handle multiple downloads at the same time and cancel each one of them if user wants but I avoided to implement that into PlayCover for multiple reasons like Installer.
DownloadApp class usage example: