Skip to content

Switch from optool to inject #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 16, 2022
Merged

Switch from optool to inject #554

merged 4 commits into from
Dec 16, 2022

Conversation

IsaacMarovitz
Copy link
Member

No description provided.

@IsaacMarovitz IsaacMarovitz mentioned this pull request Dec 6, 2022
Closed
@Depal1 Depal1 added enhancement New feature or request help wanted / caution Extra attention is needed ignore-for-release labels Dec 6, 2022
@Depal1 Depal1 added squash Indicates whether a PR must be squashed before being merged and removed ignore-for-release labels Dec 15, 2022
@IsaacMarovitz IsaacMarovitz marked this pull request as ready for review December 16, 2022 04:24
@IsaacMarovitz IsaacMarovitz removed the help wanted / caution Extra attention is needed label Dec 16, 2022
Depal1
Depal1 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@Depal1 Depal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For code injection beyond PlayTools, it would be necessary to expose the inject cli for use on Terminal. This can be done in a later PR since the current one is self contained, and it replaces the functionalities of optool correctly.

@Depal1 Depal1 merged commit bae72a2 into PlayCover:develop Dec 16, 2022
@IsaacMarovitz IsaacMarovitz deleted the byebye-optool branch December 27, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Depal1 Depal1 Depal1 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request squash Indicates whether a PR must be squashed before being merged
Projects
3.1.x - 3.2.0
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IsaacMarovitz @Depal1