feat: (slightly) more robust uri handler #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depal1
previously requested changes
Dec 4, 2022
There was a problem hiding this comment.
A viable obfuscation method needs to be figured out for the very particular case of an app targeting the url schema as an unwanted “PlayCover detection”. For more information there is a proposal for an impersonation scheme stated in the comments of #534. Having none might not pose an immediate threat to PlayCover compatibility, but we need to plan ahead since this could impact the app’s core functionality as jailbreak detection does.
P.D. I will be able to resume work here in about a week.
This comment was marked as outdated.
This comment was marked as outdated.
This would (probably) require something fairly silly (like, modifying Info.plist while PlayCover is running) that I am not sure will work. Difficult at best |
23ad166 to
5da203a
Compare
5da203a to
1fbf718
Compare
Depal1
requested changes
Feb 15, 2023
amirsaam
reviewed
Feb 16, 2023
Depal1
approved these changes
Feb 23, 2023
XuYicong
pushed a commit
to XuYicong/PlayCover
that referenced
this pull request
Mar 4, 2023
* feat: (slightly) more robust URI Handler * fix: behavior tweaks * chore: undo Cartfile.resolved changes * fix: use host instead of path for uri parsing * chore: remove print statement * fix: even tighter checks
IsaacMarovitz
pushed a commit
to IsaacMarovitz/PlayCover
that referenced
this pull request
Mar 11, 2023
* feat: (slightly) more robust URI Handler * fix: behavior tweaks * chore: undo Cartfile.resolved changes * fix: use host instead of path for uri parsing * chore: remove print statement * fix: even tighter checks
JoseMoreville
added a commit
that referenced
this pull request
Dec 11, 2023
* Add sparkle updat push to CI * add workflow_dispatch to the build actions * fix: wait until build job is done to start sparkle job * fix: invalid yaml structure * fix: invalid yaml structure * load config from .config * fix swift lint * Better clear app preferences error checking * improve appcast * update updater setting * disable CI for appcast * correct appcast url * remove nightly update channel * fix user customized config * Update Cartfile * PlayTools v2.0.7 * Bugfix release 2.0.4 * Translations update from Hosted Weblate (#747) * Translated using Weblate (Catalan) Currently translated at 0.0% (0 of 214 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ca/ Translation: PlayCover/PlayCover * Translated using Weblate (Russian) Currently translated at 96.2% (206 of 214 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ru/ Translation: PlayCover/PlayCover * Translated using Weblate (Indonesian) Currently translated at 78.9% (169 of 214 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/id/ Translation: PlayCover/PlayCover * Translated using Weblate (Japanese) Currently translated at 97.1% (208 of 214 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ja/ Translation: PlayCover/PlayCover * Translated using Weblate (Portuguese (Brazil)) Currently translated at 96.7% (207 of 214 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/pt_BR/ Translation: PlayCover/PlayCover * Translated using Weblate (Hindi) Currently translated at 97.1% (208 of 214 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/hi/ Translation: PlayCover/PlayCover * Translated using Weblate (French) Currently translated at 96.7% (207 of 214 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/fr/ Translation: PlayCover/PlayCover * Translated using Weblate (Korean) Currently translated at 96.7% (207 of 214 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ko/ Translation: PlayCover/PlayCover * Translated using Weblate (Persian) Currently translated at 99.0% (212 of 214 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/fa/ Translation: PlayCover/PlayCover * Translated using Weblate (Romanian) Currently translated at 78.9% (169 of 214 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ro/ Translation: PlayCover/PlayCover * Translated using Weblate (Turkish) Currently translated at 96.7% (207 of 214 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/tr/ Translation: PlayCover/PlayCover * Translated using Weblate (German) Currently translated at 100.0% (214 of 214 strings) Translated using Weblate (German) Currently translated at 99.0% (212 of 214 strings) Translated using Weblate (German) Currently translated at 100.0% (212 of 212 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: SkyrilHD <skyrilhd@gmail.com> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/de/ Translation: PlayCover/PlayCover * Translated using Weblate (Spanish) Currently translated at 100.0% (214 of 214 strings) Translated using Weblate (Spanish) Currently translated at 99.0% (212 of 214 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: gallegonovato <fran-carro@hotmail.es> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/es/ Translation: PlayCover/PlayCover * Translated using Weblate (Vietnamese) Currently translated at 100.0% (214 of 214 strings) Translated using Weblate (Vietnamese) Currently translated at 99.0% (212 of 214 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Trần Thanh <tranthanh2001@outlook.com> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/vi/ Translation: PlayCover/PlayCover * Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (214 of 214 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 99.0% (212 of 214 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (212 of 212 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: weng weng <carlchina@gmail.com> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/zh_Hans/ Translation: PlayCover/PlayCover * Translated using Weblate (Chinese (Traditional)) Currently translated at 99.0% (212 of 214 strings) Translated using Weblate (Chinese (Traditional)) Currently translated at 99.0% (212 of 214 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Araide <aaronhu219@gmail.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/zh_Hant/ Translation: PlayCover/PlayCover --------- Co-authored-by: SkyrilHD <skyrilhd@gmail.com> Co-authored-by: gallegonovato <fran-carro@hotmail.es> Co-authored-by: Trần Thanh <tranthanh2001@outlook.com> Co-authored-by: weng weng <carlchina@gmail.com> Co-authored-by: Araide <aaronhu219@gmail.com> * Adds toggle to fix screen issues with some apps in adaptive mode (#781) * Adding toggle to fix screen issues with some apps in adaptive mode * Fix pre 13.2 test * Adding macOS Version to app plist * Window fix toggle available for any setting up to 13.1 This fixes responsive for certain apps * Remove macOSVersion * change url scheme to apple-magnifier * feat: high resolution warning (#802) * feat: (slightly) more robust uri handler (#538) * feat: (slightly) more robust URI Handler * fix: behavior tweaks * chore: undo Cartfile.resolved changes * fix: use host instead of path for uri parsing * chore: remove print statement * fix: even tighter checks * Translations update from Hosted Weblate (#803) * Translated using Weblate (Russian) Currently translated at 86.0% (198 of 230 strings) Translated using Weblate (Russian) Currently translated at 86.4% (198 of 229 strings) Translated using Weblate (Russian) Currently translated at 87.2% (198 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ru/ Translation: PlayCover/PlayCover * Translated using Weblate (Indonesian) Currently translated at 70.4% (162 of 230 strings) Translated using Weblate (Indonesian) Currently translated at 70.7% (162 of 229 strings) Translated using Weblate (Indonesian) Currently translated at 71.3% (162 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/id/ Translation: PlayCover/PlayCover * Translated using Weblate (Japanese) Currently translated at 94.3% (217 of 230 strings) Translated using Weblate (Japanese) Currently translated at 86.9% (200 of 230 strings) Translated using Weblate (Japanese) Currently translated at 87.3% (200 of 229 strings) Translated using Weblate (Japanese) Currently translated at 88.1% (200 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: ささ <hayato.corocoro@gmail.com> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ja/ Translation: PlayCover/PlayCover * Translated using Weblate (Korean) Currently translated at 88.2% (203 of 230 strings) Translated using Weblate (Korean) Currently translated at 88.6% (203 of 229 strings) Translated using Weblate (Korean) Currently translated at 89.4% (203 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ko/ Translation: PlayCover/PlayCover * Translated using Weblate (Persian) Currently translated at 88.2% (203 of 230 strings) Translated using Weblate (Persian) Currently translated at 88.6% (203 of 229 strings) Translated using Weblate (Persian) Currently translated at 89.4% (203 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/fa/ Translation: PlayCover/PlayCover * Translated using Weblate (Romanian) Currently translated at 70.4% (162 of 230 strings) Translated using Weblate (Romanian) Currently translated at 70.7% (162 of 229 strings) Translated using Weblate (Romanian) Currently translated at 71.3% (162 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ro/ Translation: PlayCover/PlayCover * Translated using Weblate (Catalan) Currently translated at 0.0% (0 of 230 strings) Translated using Weblate (Catalan) Currently translated at 0.0% (0 of 229 strings) Translated using Weblate (Catalan) Currently translated at 0.0% (0 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ca/ Translation: PlayCover/PlayCover * Translated using Weblate (Chinese (Traditional)) Currently translated at 100.0% (230 of 230 strings) Translated using Weblate (Chinese (Traditional)) Currently translated at 95.6% (220 of 230 strings) Translated using Weblate (Chinese (Traditional)) Currently translated at 96.0% (220 of 229 strings) Translated using Weblate (Chinese (Traditional)) Currently translated at 96.9% (220 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Araide <aaronhu219@gmail.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/zh_Hant/ Translation: PlayCover/PlayCover * Translated using Weblate (Turkish) Currently translated at 89.1% (205 of 230 strings) Translated using Weblate (Turkish) Currently translated at 89.5% (205 of 229 strings) Translated using Weblate (Turkish) Currently translated at 90.3% (205 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/tr/ Translation: PlayCover/PlayCover * Translated using Weblate (Hindi) Currently translated at 86.9% (200 of 230 strings) Translated using Weblate (Hindi) Currently translated at 87.3% (200 of 229 strings) Translated using Weblate (Hindi) Currently translated at 88.1% (200 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/hi/ Translation: PlayCover/PlayCover * Translated using Weblate (Portuguese (Brazil)) Currently translated at 86.5% (199 of 230 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 86.8% (199 of 229 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 87.6% (199 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/pt_BR/ Translation: PlayCover/PlayCover * Translated using Weblate (Spanish) Currently translated at 100.0% (230 of 230 strings) Translated using Weblate (Spanish) Currently translated at 99.5% (229 of 230 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (229 of 229 strings) Translated using Weblate (Spanish) Currently translated at 99.1% (227 of 229 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (227 of 227 strings) Translated using Weblate (Spanish) Currently translated at 96.9% (220 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: gallegonovato <fran-carro@hotmail.es> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/es/ Translation: PlayCover/PlayCover * Translated using Weblate (German) Currently translated at 100.0% (230 of 230 strings) Translated using Weblate (German) Currently translated at 99.5% (229 of 230 strings) Translated using Weblate (German) Currently translated at 100.0% (229 of 229 strings) Translated using Weblate (German) Currently translated at 96.0% (220 of 229 strings) Translated using Weblate (German) Currently translated at 96.9% (220 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: SkyrilHD <skyrilhd@gmail.com> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/de/ Translation: PlayCover/PlayCover * Translated using Weblate (Vietnamese) Currently translated at 95.6% (220 of 230 strings) Translated using Weblate (Vietnamese) Currently translated at 96.0% (220 of 229 strings) Translated using Weblate (Vietnamese) Currently translated at 96.9% (220 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/vi/ Translation: PlayCover/PlayCover * Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (230 of 230 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 95.6% (220 of 230 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 96.0% (220 of 229 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 96.9% (220 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Araide <aaronhu219@gmail.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/zh_Hans/ Translation: PlayCover/PlayCover * Translated using Weblate (French) Currently translated at 95.6% (220 of 230 strings) Translated using Weblate (French) Currently translated at 96.0% (220 of 229 strings) Translated using Weblate (French) Currently translated at 96.9% (220 of 227 strings) Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/fr/ Translation: PlayCover/PlayCover --------- Co-authored-by: ささ <hayato.corocoro@gmail.com> Co-authored-by: Araide <aaronhu219@gmail.com> Co-authored-by: gallegonovato <fran-carro@hotmail.es> Co-authored-by: SkyrilHD <skyrilhd@gmail.com> * fix: deselect app on uninstall (#792) * fix version control mark in jp localization strings * PlayTools v2.1.0 * Bug fix release 2.0.5 * change inject cmdType for inject 1.1.0 * fix workflows --------- Co-authored-by: Candygoblen123 <andrew.glaze76@gmail.com> Co-authored-by: lucas lee <lixin9311@gmail.com> Co-authored-by: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com> Co-authored-by: Depal1 <47154119+Depal1@users.noreply.github.com> Co-authored-by: José Moreno <47700212+JoseMoreville@users.noreply.github.com> Co-authored-by: Weblate (bot) <hosted@weblate.org> Co-authored-by: SkyrilHD <skyrilhd@gmail.com> Co-authored-by: gallegonovato <fran-carro@hotmail.es> Co-authored-by: Trần Thanh <tranthanh2001@outlook.com> Co-authored-by: weng weng <carlchina@gmail.com> Co-authored-by: Araide <aaronhu219@gmail.com> Co-authored-by: OHaiiBuzzle <23693150+ohaiibuzzle@users.noreply.github.com> Co-authored-by: ささ <hayato.corocoro@gmail.com> Co-authored-by: Xyct <87l46110@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a new, (slightly) more robust URI handler for the
playcover:URI scheme, with support for adding sources directly from other applicationsAlso includes RuntimeVM, which is like StoreVM, but is not persistent, which can be useful for passing around temp data later.
Example:
playcover://source?action=add&url=<source_url>