Skip to content

Conversation

IsaacMarovitz
Copy link
Member

No description provided.

IsaacMarovitz and others added 30 commits October 26, 2022 01:32
Fix crash when downloading apps
Do not add `UISupportsTrueScreenSizeOnMac` to apps.

Per Apple documentation, this key tells macOS the app is (among other things) capable of handling any display size and "all conceivable aspect ratios", which is obviously something we can't presume. I can image this would (if the window was visible) cause other bugs to pop up around UI and input mapping.

Finally, the actual reason windows aren't visible is actually pretty simple.
The root application delegate class for iOS on Mac apps (`UINSApplicationDelegate`) receives a `didCreateUIScene` callback (or notification, didn't look much further into it) on `didCreateUIScene:transitionContextDictionary:` which falls through to `_configureWindowControllerCreatingIfNeededForScene:transitionContextDictionary:` where the main window controller is created. The root class for iOS on Mac (and Catalyst) window controllers is `UINSSceneWindowController` which has a method called `_showWindowPostLoadIsFirstWindow:transitionContextDictionary:` (invoked during  `_configureWindowController...`) which checks for the `UISupportsTrueScreenSizeOnMac` key and SKIPS calling `[NSWindow makeKeyAndOrderFront:]` if found.

tl;dr: Window controller never calls `[NSWindow makeKeyAndOrderFront:]` if `UISupportsTrueScreenSizeOnMac` is true.
Currently translated at 97.7% (175 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/pt_BR/
Translation: PlayCover/PlayCover
Currently translated at 77.0% (138 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/zh_Hant/
Translation: PlayCover/PlayCover
Currently translated at 2.7% (5 of 179 strings)

Translated using Weblate (German)

Currently translated at 1.1% (2 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: TheMoonThatRises <rangerwillyt@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/de/
Translation: PlayCover/PlayCover
Currently translated at 100.0% (179 of 179 strings)

Translated using Weblate (French)

Currently translated at 97.7% (175 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: ZhichGaming <nick.zhicheng@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/fr/
Translation: PlayCover/PlayCover
Currently translated at 34.6% (62 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ru/
Translation: PlayCover/PlayCover
Currently translated at 14.5% (26 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Arabic)

Currently translated at 14.5% (26 of 179 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Nabrious <nabrious@icloud.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ar/
Translation: PlayCover/PlayCover
Currently translated at 39.6% (71 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/uk/
Translation: PlayCover/PlayCover
Currently translated at 100.0% (179 of 179 strings)

Translated using Weblate (Indonesian)

Currently translated at 1.1% (2 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Rayhan Ihsan <meow2681@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/id/
Translation: PlayCover/PlayCover
Currently translated at 1.1% (2 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/it/
Translation: PlayCover/PlayCover
Currently translated at 89.3% (160 of 179 strings)

Translated using Weblate (Japanese)

Currently translated at 65.9% (118 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Japanese)

Currently translated at 67.0% (120 of 179 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: ささ <hayato.corocoro@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ja/
Translation: PlayCover/PlayCover
Currently translated at 97.7% (175 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/es/
Translation: PlayCover/PlayCover
Currently translated at 100.0% (179 of 179 strings)

Translated using Weblate (Vietnamese)

Currently translated at 97.7% (175 of 179 strings)

Translated using Weblate (Vietnamese)

Currently translated at 97.7% (175 of 179 strings)

Translated using Weblate (Vietnamese)

Currently translated at 97.7% (175 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Vietnamese)

Currently translated at 100.0% (179 of 179 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Trần Thanh <tranthanh2001@outlook.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/vi/
Translation: PlayCover/PlayCover
Currently translated at 100.0% (179 of 179 strings)

Translated using Weblate (Chinese (Simplified))

Currently translated at 97.7% (175 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (179 of 179 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: weng weng <carlchina@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/zh_Hans/
Translation: PlayCover/PlayCover
Currently translated at 100.0% (179 of 179 strings)

Translated using Weblate (Persian)

Currently translated at 97.7% (175 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Amir Mohammadi <amirkamangar@icloud.com>
Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/fa/
Translation: PlayCover/PlayCover
Currently translated at 100.0% (179 of 179 strings)

Translated using Weblate (Korean)

Currently translated at 100.0% (179 of 179 strings)

Translated using Weblate (Korean)

Currently translated at 97.7% (175 of 179 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: 안재범 <ajb8533296@gmail.com>
Co-authored-by: 이정희 <daemul72@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ko/
Translation: PlayCover/PlayCover
Translations update from Hosted Weblate
Add Turkish and Romanian Locales
* tiktok blacklisting

* fix

* Update project.pbxproj

* Update Cartfile.resolved

* Update PlayApp.swift

* Update PlayApp.swift

* rewrite of my original pr. for titktok blacklisting

* polishing

* Update PlayApp.swift

* Update StoreAppView.swift

* Update StoreAppView.swift

* Update PlayApp.swift

* Update StoreAppView.swift
* fix: make install playtools clearer

* feat: change PlayTools installation behavior (#1)

* simplify if-statement + swiftlint

* fix trailing whitespace

* clarify PlayTools make break certain apps

* fix AKInterface installing despite no PlayTools

Restores app to original state

* allow user to cancel install with popup

* make install preferences consistent with uninstall

* remove PlugIn directory if it is empty

Some apps use the PlugIn directory to store their own plugins

* Update PlayCover/en.lproj/Localizable.strings

Co-authored-by: OHaiiBuzzle <23693150+ohaiibuzzle@users.noreply.github.com>
Co-authored-by: Depal1 <47154119+Depal1@users.noreply.github.com>
IsaacMarovitz and others added 11 commits November 2, 2022 16:20
Not fully working yet
* Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (181 of 181 strings)

Translated using Weblate (Portuguese (Brazil))

Currently translated at 98.8% (179 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (180 of 180 strings)

Translated using Weblate (Portuguese (Brazil))

Currently translated at 99.4% (179 of 180 strings)

Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (179 of 179 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hayato Fujii <hayato.fujii@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/pt_BR/
Translation: PlayCover/PlayCover

* Translated using Weblate (Chinese (Traditional))

Currently translated at 98.8% (179 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Chinese (Traditional))

Currently translated at 100.0% (180 of 180 strings)

Translated using Weblate (Chinese (Traditional))

Currently translated at 76.6% (138 of 180 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: rootmelo92118 <rootmelo92118@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/zh_Hant/
Translation: PlayCover/PlayCover

* Translated using Weblate (German)

Currently translated at 2.7% (5 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (German)

Currently translated at 2.7% (5 of 180 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/de/
Translation: PlayCover/PlayCover

* Translated using Weblate (French)

Currently translated at 98.3% (178 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (French)

Currently translated at 99.4% (179 of 180 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/fr/
Translation: PlayCover/PlayCover

* Translated using Weblate (Russian)

Currently translated at 34.2% (62 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Russian)

Currently translated at 34.4% (62 of 180 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ru/
Translation: PlayCover/PlayCover

* Translated using Weblate (Ukrainian)

Currently translated at 39.2% (71 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Ukrainian)

Currently translated at 39.4% (71 of 180 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/uk/
Translation: PlayCover/PlayCover

* Translated using Weblate (Indonesian)

Currently translated at 98.3% (178 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Indonesian)

Currently translated at 99.4% (179 of 180 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/id/
Translation: PlayCover/PlayCover

* Translated using Weblate (Italian)

Currently translated at 1.1% (2 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Italian)

Currently translated at 1.1% (2 of 180 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/it/
Translation: PlayCover/PlayCover

* Translated using Weblate (Japanese)

Currently translated at 87.8% (159 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Japanese)

Currently translated at 88.8% (160 of 180 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ja/
Translation: PlayCover/PlayCover

* Translated using Weblate (Spanish)

Currently translated at 96.1% (174 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Spanish)

Currently translated at 97.2% (175 of 180 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/es/
Translation: PlayCover/PlayCover

* Translated using Weblate (Romanian)

Currently translated at 98.3% (178 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Romanian)

Currently translated at 99.4% (179 of 180 strings)

Translated using Weblate (Romanian)

Currently translated at 100.0% (179 of 179 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Rosie <acquitefx@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ro/
Translation: PlayCover/PlayCover

* Translated using Weblate (Turkish)

Currently translated at 31.4% (57 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Turkish)

Currently translated at 31.6% (57 of 180 strings)

Translated using Weblate (Turkish)

Currently translated at 31.8% (57 of 179 strings)

Translated using Weblate (Turkish)

Currently translated at 22.3% (40 of 179 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Claws <clawsdiction@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/tr/
Translation: PlayCover/PlayCover

* Translated using Weblate (Vietnamese)

Currently translated at 100.0% (181 of 181 strings)

Translated using Weblate (Vietnamese)

Currently translated at 98.3% (178 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Vietnamese)

Currently translated at 99.4% (179 of 180 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: OHaiiBuzzle <ohaibuzzle@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/vi/
Translation: PlayCover/PlayCover

* Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (181 of 181 strings)

Translated using Weblate (Chinese (Simplified))

Currently translated at 98.8% (179 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (180 of 180 strings)

Translated using Weblate (Chinese (Simplified))

Currently translated at 99.4% (179 of 180 strings)

Co-authored-by: Adam C <adam701212@gmail.com>
Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: weng weng <carlchina@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/zh_Hans/
Translation: PlayCover/PlayCover

* Translated using Weblate (Persian)

Currently translated at 100.0% (181 of 181 strings)

Translated using Weblate (Persian)

Currently translated at 98.3% (178 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Persian)

Currently translated at 99.4% (179 of 180 strings)

Co-authored-by: Amir Mohammadi <amirkamangar@icloud.com>
Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/fa/
Translation: PlayCover/PlayCover

* Translated using Weblate (Korean)

Currently translated at 98.3% (178 of 181 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translated using Weblate (Korean)

Currently translated at 99.4% (179 of 180 strings)

Translated using Weblate (Korean)

Currently translated at 100.0% (179 of 179 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: 안재범 <ajb8533296@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ko/
Translation: PlayCover/PlayCover

* Update translation files

Updated by "Squash Git commits" hook in Weblate.

Translation: PlayCover/PlayCover
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/

Co-authored-by: Hayato Fujii <hayato.fujii@gmail.com>
Co-authored-by: rootmelo92118 <rootmelo92118@gmail.com>
Co-authored-by: Rosie <acquitefx@gmail.com>
Co-authored-by: Claws <clawsdiction@gmail.com>
Co-authored-by: OHaiiBuzzle <ohaibuzzle@gmail.com>
Co-authored-by: Adam C <adam701212@gmail.com>
Co-authored-by: weng weng <carlchina@gmail.com>
Co-authored-by: Amir Mohammadi <amirkamangar@icloud.com>
Co-authored-by: 안재범 <ajb8533296@gmail.com>
* Remove Arabic

* Update Localizable.strings

Co-authored-by: Depal1 <47154119+Depal1@users.noreply.github.com>
@Depal1 Depal1 merged commit e573763 into stable Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants