Skip to content

Implement Discord Activity(Rich Presence) #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2022
Merged

Implement Discord Activity(Rich Presence) #49

merged 1 commit into from
Aug 28, 2022

Conversation

KhoraLee
Copy link
Contributor

@KhoraLee KhoraLee commented Jul 16, 2022 •
edited
Loading

This PR implement discord activity(also known as Rich Presence) feature.
When you open app from PlayCover, PlayCover/PlayTools#2 will connect to discord client via IPC and update activity.

Default activity looks like below.

image Default Activity

Because discord does not allow us to change name of application, It will display name as PlayCover and show application name(from bundle) in detail field.

But user can set specific application name by creating their own application in Discord Developer Portal. Also user can change details, state string and image shown at left side.

By setting custom activity like below, user can deliver discord activity as their wish.

image 스크린샷 2022-07-16 오후 5 44 56image 스크린샷 2022-07-16 오후 5 45 15

@KhoraLee KhoraLee marked this pull request as draft July 16, 2022 08:56
@KhoraLee KhoraLee mentioned this pull request Jul 16, 2022
Merged
@KhoraLee KhoraLee force-pushed the feature/discord-activity branch from 599ac4b to 5c10497 Compare July 16, 2022 09:05
@KhoraLee KhoraLee marked this pull request as ready for review July 16, 2022 09:06
@lixin9311
Copy link
Contributor

This is coool 🔥

@Depal1 Depal1 added the enhancement New feature or request label Jul 19, 2022
@Depal1
Copy link
Member

Depal1 commented Jul 22, 2022

Hi! There was a merge with a lot of style fixes all over the code. Hence, a rebase is required.

@KhoraLee KhoraLee force-pushed the feature/discord-activity branch from 5c10497 to 3200862 Compare July 22, 2022 10:02
@KhoraLee
Copy link
Contributor Author

@Depal1
Rebased, thx.

@KhoraLee KhoraLee force-pushed the feature/discord-activity branch 3 times, most recently from 974a2c6 to cf65c50 Compare July 31, 2022 05:03
@Depal1 Depal1 requested a review from lixin9311 July 31, 2022 07:26
@IsaacMarovitz
Copy link
Member

Text will need to be reworked to follow #86 locale style.

@KhoraLee KhoraLee force-pushed the feature/discord-activity branch 2 times, most recently from 4158f7c to c48682a Compare August 1, 2022 20:13
@Candygoblen123 Candygoblen123 mentioned this pull request Aug 3, 2022
Closed
2 tasks
@KhoraLee KhoraLee force-pushed the feature/discord-activity branch from c48682a to e5792c6 Compare August 6, 2022 03:56
@KhoraLee KhoraLee force-pushed the feature/discord-activity branch from e5792c6 to a5373a4 Compare August 19, 2022 15:51
@ZhichGaming
Copy link
Contributor

Rich Presence does not work for me. I used the ID with the ID if found with right click on profile > Copy ID. I tried disabling and reenabling Enable Discord Activity but it still does not even show PlayCover(or the app launched) on my profile.
Screen Shot 2022-08-24 at 21 44 55

@KhoraLee
Copy link
Contributor Author

@ZhichGaming
If the Carthage.resolved file is not same with github "KhoraLee/PlayTools" "b8d607a8da22a9ffbbde7006828db01cba73238a" then do carthage update --use-xcframeworks and try again

@ZhichGaming
Copy link
Contributor

Thanks, it now works! And pretty quickly at that! I didn't even need to configure anything in the Discord Developer Portal except needing to create the application. I'd suggest that instead of ClientID, it should be Application ID since it's called that in the dev portal. People would get confused with User ID.
Screen Shot 2022-08-25 at 15 34 04

@KhoraLee KhoraLee changed the base branch from develop to 2.0-UI August 27, 2022 16:08
@KhoraLee KhoraLee force-pushed the feature/discord-activity branch 2 times, most recently from 67eb98e to fc4d915 Compare August 27, 2022 18:05
@KhoraLee KhoraLee force-pushed the feature/discord-activity branch from fc4d915 to 6f2290f Compare August 27, 2022 18:06
@Depal1 Depal1 merged commit ce1b907 into PlayCover:2.0-UI Aug 28, 2022
@KhoraLee KhoraLee deleted the feature/discord-activity branch August 29, 2022 15:28
@DarthMDev
Copy link

Why are some app defaults for the images genshin impact?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Depal1 Depal1 Depal1 approved these changes

@lixin9311 lixin9311 Awaiting requested review from lixin9311

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
3.1.x - 3.2.0
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KhoraLee @lixin9311 @Depal1 @IsaacMarovitz @ZhichGaming @DarthMDev