Skip to content

Conversation

Amachik
Copy link
Contributor

@Amachik Amachik commented Nov 1, 2022

problem with merging via desynced files.

@Amachik
Copy link
Contributor Author

Amachik commented Nov 1, 2022

it should be all fixed now. i hope.

@Amachik Amachik marked this pull request as ready for review November 1, 2022 17:57
Copy link
Contributor Author

@Amachik Amachik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me.

@TheMoonThatRises
Copy link
Member

it should be all fixed now. i hope.

Unfortunately, there is one in StoreAppView that still isn't fixed.

@Amachik
Copy link
Contributor Author

Amachik commented Nov 1, 2022

it should be all fixed now. i hope.

Unfortunately, there is one in StoreAppView that still isn't fixed.

huh? what is it this time? im not discarding any changes

Copy link
Contributor Author

@Amachik Amachik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im done with it >}

@amirsaam
Copy link
Member

amirsaam commented Nov 1, 2022

Can we also prohibit users from installing it?
Malicious apps are different with regular prohibited, those are ban risks and users can bypass it with no real damage, but malicious are red flag, users should not be able to install it through PlayCover.

@Amachik
Copy link
Contributor Author

Amachik commented Nov 1, 2022

Can we also prohibit users from installing it?
Malicious apps are different with regular prohibited, those are ban risks and users can bypass it with no real damage, but malicious are red flag, users should not be able to install it through PlayCover.

i can def. add this feature in addition to this. i will add this later on. this pr is now complete.

@Depal1 Depal1 added the squash Indicates whether a PR must be squashed before being merged label Nov 1, 2022
@Depal1 Depal1 merged commit c260ab6 into PlayCover:develop Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squash Indicates whether a PR must be squashed before being merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants