Fix #397 (invisible windows) #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not add `UISupportsTrueScreenSizeOnMac` to apps. Per Apple documentation, this key tells macOS the app is (among other things) capable of handling any display size and "all conceivable aspect ratios", which is obviously something we can't presume. I can image this would (if the window was visible) cause other bugs to pop up around UI and input mapping. Finally, the actual reason windows aren't visible is actually pretty simple. The root application delegate class for iOS on Mac apps (`UINSApplicationDelegate`) receives a `didCreateUIScene` callback (or notification, didn't look much further into it) on `didCreateUIScene:transitionContextDictionary:` which falls through to `_configureWindowControllerCreatingIfNeededForScene:transitionContextDictionary:` where the main window controller is created. The root class for iOS on Mac (and Catalyst) window controllers is `UINSSceneWindowController` which has a method called `_showWindowPostLoadIsFirstWindow:transitionContextDictionary:` (invoked during `_configureWindowController...`) which checks for the `UISupportsTrueScreenSizeOnMac` key and SKIPS calling `[NSWindow makeKeyAndOrderFront:]` if found. tl;dr: Window controller never calls `[NSWindow makeKeyAndOrderFront:]` if `UISupportsTrueScreenSizeOnMac` is true.
IsaacMarovitz
approved these changes
Oct 31, 2022
JoseMoreville
approved these changes
Oct 31, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not add
UISupportsTrueScreenSizeOnMacto apps.Per Apple documentation, this key tells macOS the app is (among other things) capable of handling any display size and "all conceivable aspect ratios", which is obviously something we can't presume. I can image this would (if the window was visible) cause other bugs to pop up around UI and input mapping.
Finally, the actual reason windows aren't visible is actually pretty simple. The root application delegate class for iOS on Mac apps (
UINSApplicationDelegate) receives adidCreateUIScenecallback (or notification, didn't look much further into it) ondidCreateUIScene:transitionContextDictionary:which falls through to_configureWindowControllerCreatingIfNeededForScene:transitionContextDictionary:, where the main window controller is created. The root class for iOS on Mac (and Catalyst) window controllers isUINSSceneWindowControllerwhich has a method called_showWindowPostLoadIsFirstWindow:transitionContextDictionary:(invoked during_configureWindowController...) which checks for theUISupportsTrueScreenSizeOnMackey and SKIPS calling[NSWindow makeKeyAndOrderFront:]if found.tl;dr: Window controller never calls
[NSWindow makeKeyAndOrderFront:]ifUISupportsTrueScreenSizeOnMacis true.