Skip to content

Improve PlayTools installer interactions #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 2, 2022
Merged

Improve PlayTools installer interactions #453

merged 10 commits into from
Nov 2, 2022

Conversation

TheMoonThatRises
Copy link
Member

@TheMoonThatRises TheMoonThatRises commented Oct 26, 2022 •
edited
Loading

Makes the PlayTools install popup clearer by including what it does, and not appear to the regular user

  • Make install popup not popup by default, and triggered by holding option key
  • Clarify what PlayTools does and not make the button destructive
  • Allow user to cancel installation process when using the install popup
  • Remove AKInterface if PlayTools is not installed to restore app to it's original state
  • Make install popup appear only when the user presses the option key while installing or configures it in settings
  • Improved install alert

@TheMoonThatRises TheMoonThatRises marked this pull request as draft October 27, 2022 01:23
@TheMoonThatRises TheMoonThatRises marked this pull request as ready for review October 27, 2022 04:38
Hulkstern
Hulkstern approved these changes Oct 27, 2022
View reviewed changes
Copy link

@Hulkstern Hulkstern left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the playtools prompt are definitely needed clarification on the prompt.

(This was meant to be a comment, don't know why it went through as me "approving" these changes since I don't have write access)

Candygoblen123
Candygoblen123 previously requested changes Oct 27, 2022
View reviewed changes
@TheMoonThatRises TheMoonThatRises changed the title Make install PlayTools clearer Improve PlayTools install clarity Oct 27, 2022
@TheMoonThatRises TheMoonThatRises changed the title Improve PlayTools install clarity Improve PlayTools installer interactions Oct 27, 2022
@TheMoonThatRises TheMoonThatRises marked this pull request as draft October 30, 2022 03:19
@TheMoonThatRises
Copy link
Member Author

Is an install popup like this good, or would it not be needed as there won't be enough install options for this to be useful?

Screenshot 2022-10-30 at 20 58 41

@Depal1
Copy link
Member

Depal1 commented Oct 31, 2022

Is an install popup like this good, or would it not be needed as there won't be enough install options for this to be useful?

Screenshot 2022-10-30 at 20 58 41

At present, I don't think there are other install options we are considering.

@TheMoonThatRises
Copy link
Member Author

At present, I don't think there are other install options we are considering.

So should I keep the other popup?

@Candygoblen123
Copy link
Member

Is an install popup like this good, or would it not be needed as there won't be enough install options for this to be useful?

Screenshot 2022-10-30 at 20 58 41

Can you change the tooltip to be just text in the popup?

@TheMoonThatRises
Copy link
Member Author

TheMoonThatRises commented Oct 31, 2022 •
edited
Loading

Can you change the tooltip to be just text in the popup?

Like this? The main reason I have it as a tooltip is because it wouldn't be necessary text to most people who would use the menu, as they would already know what PlayTools is and does.
Screenshot 2022-10-31 at 13 26 27

@amirsaam
Copy link
Member

amirsaam commented Oct 31, 2022 •
edited by Candygoblen123
Loading

I think what candy meant is like uninstall pop up that asks if you are sure of deleting the app text. but since playtools is the only install option as @Depal1 said, it will be good if it only asks about PlayTools like:

Headline:
Inject Playtools?

Subheadline:
The Description

Buttons:

  1. Inject & Install
  2. Install w/o Playtools
  3. Cancel

@TheMoonThatRises
Copy link
Member Author

So something like this?
Screenshot 2022-10-31 at 18 47 11

@amirsaam
Copy link
Member

amirsaam commented Nov 1, 2022

It's better now but I think the options I suggested were more clear to user comparing to simple yes or no buttons, and could simplify the title.
But it's up to maintainers to decide. Thanks for your effort 👍

@TheMoonThatRises TheMoonThatRises marked this pull request as ready for review November 1, 2022 15:26
@TheMoonThatRises
remove PlugIn directory if it is empty
f780062 
Some apps use the PlugIn directory to store their own plugins
Depal1
Depal1 approved these changes Nov 2, 2022
View reviewed changes
@Depal1 Depal1 added the squash Indicates whether a PR must be squashed before being merged label Nov 2, 2022
@Depal1 Depal1 dismissed Candygoblen123’s stale review November 2, 2022 15:22

The requested changes have been addressed, and accepted by the requester.

@Depal1 Depal1 merged commit e11f558 into PlayCover:develop Nov 2, 2022
@TheMoonThatRises TheMoonThatRises deleted the fix/playtoolsinstallclarity branch January 1, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Depal1 Depal1 Depal1 approved these changes

@Candygoblen123 Candygoblen123 Awaiting requested review from Candygoblen123

+1 more reviewer

@Hulkstern Hulkstern Hulkstern approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
squash Indicates whether a PR must be squashed before being merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TheMoonThatRises @Depal1 @Candygoblen123 @amirsaam @Hulkstern @ohaiibuzzle