Skip to content

Conversation

sayoun
Copy link
Contributor

@sayoun sayoun commented May 6, 2025

No description provided.

sayoun added 2 commits May 6, 2025 23:06
introduce a testing mocked ftp server
@sayoun sayoun changed the title Add stdio and ftp exporter tests Add stdio and ftp importer and exporter tests May 11, 2025
@sayoun sayoun requested a review from poolpOrg May 11, 2025 15:55
Copy link
Contributor

@omar-polo omar-polo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay. i can't comment much on the ftp mock part -- i'm not familiar enough with the inner workings of the protocol -- but otherwise looks good to me.

left some nitpicks, but could also go in as-is and improved in tree.

@poolpOrg poolpOrg merged commit 39815fe into PlakarKorp:main Jun 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants