fix: Improve update check logic to handle beta releases and recent version validation #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the built app under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/16030155927 |
zupo
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refines the application update check to properly filter beta releases, handle cases with no available releases, and only fail the update check if the latest release is more than 10 days old and the app version does not match.
- Inverts and clarifies the
showBetafilter logic with explicit logging. - Adds guards for no available releases and date parsing failures.
- Introduces a 10-day grace period, strips pre-release suffixes, and compares the app’s version against the latest release.
Comments suppressed due to low confidence (1)
Pareto/Checks/Application Updates/ParetoUpdated.swift:103
- This new conditional logic introduces a grace period and pre-release suffix stripping but there are no corresponding unit tests; consider adding tests to cover both branches (older and within 10-day releases).
if publishedDate < tenDaysAgo {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only fails if the latest stable release is older than 10 days AND the current version doesn't match
ref: https://github.com/teamniteo/pareto/issues/734