Add error handling and logging improvements across various app checks #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the built app under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/15323050497 |
|
You can find the built app under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/15320368496 |
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling and logging across the app’s various version check mechanisms by introducing and utilizing the hasError property. Key changes include updating CFBundleVersion in the app plist, adding hasError flag updates in multiple AppCheck subclasses, and refining update logic in application update checks.
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Pareto/Info.plist | Updated CFBundleVersion from 5664 to 5709 |
| Pareto/Checks/Zoom.swift, VSCode.swift, SublimeText.swift, etc. | Added error flag (hasError) setting on failure |
| Pareto/Checks/ParetoCheck.swift | Introduced hasError property and resets it before check execution |
| Pareto/Checks/Claim.swift | Added computed property checksNoError with combined check logic |
| Pareto/Checks/Application Updates/ParetoUpdated.swift | Enhanced release filtering and logging with hasError on failure |
zupo
approved these changes
May 29, 2025
- Introduced `hasError` property in `AppCheck` and its subclasses to track errors during version checks.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
f212c76 to
635f53d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasErrorproperty inAppCheckand its subclasses to track errors during version checks.Can be merged before Dash changes, but not released.
ref: https://github.com/teamniteo/pareto/issues/715