Ensure PBC box vectors are in reduced form for OpenMM #1368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally was getting an error from OpenMM that box vectors were not in the reduced form that it expects after exporting a trajectory frame into an Amber restart file and starting from that with ParmEd (perhaps natively produced restart files are already in reduced form). Interestingly, ParmEd already has the function
reduce_box_vectors
that is used when loading from GROMACS gro files, so I just applied that in the openmm simulations module to enforce it.