Skip to content

missing check for DihedralType in Dihedral.funct #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2021
Merged

missing check for DihedralType in Dihedral.funct #1170

merged 3 commits into from
May 13, 2021

Conversation

anabiman
Copy link
Contributor

@anabiman anabiman commented Apr 23, 2021 •
edited
Loading

The funct property in the Dihedral class can return incorrect self._funct when self.type is DihedralType. This ensures Dihedral.funct checks for DihedralType and subsequently returns 1.

swails
swails approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@swails swails left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@swails swails merged commit 1e5e63c into ParmEd:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swails swails swails approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anabiman @swails