[ISSUE-310] Added ignore for uuids in security group rules #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem? The uuid returned from an existing rule was causing all security rules to show as if they had changes even when no changes to the rules would be made. Solution! Added an `ignore_uuid` flag to the `apply_state` helper so that we would be able to selectively ignore the uuid for certain objects, like security group rules, where we don't yet support uuid as a parameter.
|
@shinmog , @ivanbojer we would like to request review of this PR. |
|
@shinmog , @ivanbojer : bump |
|
Looking forward to seeing this fix being merged, it's been annoying to have false positive because of the UUID |
|
Implemented this for all the policy rule modules, and will be included in the next release. Closing this out as it is now obsoleted. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an
ignore_uuidflag to theapply_statehelper so that we wouldbe able to selectively ignore the uuid for certain objects, like
security group rules, where we don't yet support uuid as a parameter.
Motivation and Context
The uuid returned from an existing rule was causing all security
rules to show as if they had changes even when no changes to the rules
would be made.
This change addresses ISSUE-310
How Has This Been Tested?
Used the updated module to rerun existing playbooks with security group rules and confirmed that no changes were reported after running the playbooks.