fix!: gathered_filter to process regex correctly #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed backslash(\) escape char from shlex to avoid escaping and properly processing regex expressions.
3c5eb74 to
15226e3
Compare
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2025
## [3.0.0](v2.21.4...v3.0.0) (2025-05-16) ### ⚠ BREAKING CHANGES * merge beta to develop for a new major release (#618) * drop crypto_profile_name alias in panos_ike_gateway * `gathered_filter` in 'gathered' state now accepts valid regex expressions, the previous syntax with extra escape characters is not valid anymore. ### Bug Fixes * gathered_filter to process regex correctly ([#583](#583)) ([ae4103a](ae4103a)) ### Miscellaneous Chores * merge beta to develop for a new major release ([#618](#618)) ([f89f05a](f89f05a)) * support ansible-core 2.16 to 2.18 - drop python 3.9 ([#604](#604)) ([3b0f5ab](3b0f5ab))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regex expressions in
gatheredstategathered_filterrequired extra escape chars which wasn't a valid regex in deed.This PR allows to write valid regex expression in the
gathered_filter, the previous syntax is not valid anymore hence this is introducing a breaking change.shlex.split()was used to split logic expressions in thegathered_filter, which also escaped(removed) backslash\chars from the expression and led to a non-working regex. We have implemented our split method using shlex but removing backslash(\) escape char from shlex instance to avoid escaping and properly processing regex expressions.Motivation and Context
Fixes #579
How Has This Been Tested?
Tested on vm firewalls with examples in the issue.
Types of changes
Checklist