Skip to content

[Docathon][Fix note No.20-24] #7150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 25, 2025
Merged

[Docathon][Fix note No.20-24] #7150

merged 10 commits into from
Mar 25, 2025

Conversation

rich04lin
Copy link
Contributor

Fix note：
docs/api/paddle/optimizer/NAdam_cn.rst
docs/api/paddle/optimizer/Optimizer_cn.rst
docs/api/paddle/optimizer/RAdam_cn.rst
docs/api/paddle/optimizer/RMSProp_cn.rst
docs/api/paddle/optimizer/SGD_cn.rst

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Mar 24, 2025

感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-7150.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明，请参考：飞桨文档预览工具

@luotao1 luotao1 mentioned this pull request Mar 25, 2025
Closed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Mar 25, 2025
Echo-Nie
Echo-Nie reviewed Mar 25, 2025
View reviewed changes
docs/api/paddle/optimizer/NAdam_cn.rst Outdated

**返回**
**返回**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Return" part does not need to be indented, only the content of the note part that needs to be annotated.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry，i have fixed my mistakes

@Echo-Nie
Copy link
Contributor

Echo-Nie commented Mar 25, 2025 •
edited
Loading

@sunzhongkai588 pls approve

@Echo-Nie
Copy link
Contributor

And I have a suggestion, just a suggestion, a PR should not contain commits that are not related to it, this should be a specification.

While it has no effect on this PR(since your previous commit has been Merged), if the commit contains the unfinished, maybe influence the review.

@rich04lin
Copy link
Contributor Author

而且我有一个建议，只是一个建议，一个 PR 不应该包含与其不相关的提交，这应该是一个规范。

虽然它对此 PR 没有影响（因为您之前的提交已被合并），但如果提交包含未完成的内容，可能会影响审查。

thank you.i forget to update .so it contains some before commits

Echo-Nie
Echo-Nie approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@Echo-Nie Echo-Nie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit d7c4db6 into PaddlePaddle:develop Mar 25, 2025
2 checks passed
@rich04lin rich04lin deleted the n20-24 branch March 25, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

+1 more reviewer

@Echo-Nie Echo-Nie Echo-Nie approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@luotao1 luotao1

@sunzhongkai588 sunzhongkai588

Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rich04lin @Echo-Nie @luotao1 @sunzhongkai588