Skip to content

[Docathon][CodeStyle Fix No.1] enable F541 rule #6274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 29, 2023
Merged

[Docathon][CodeStyle Fix No.1] enable F541 rule #6274

merged 5 commits into from
Oct 29, 2023

Conversation

ooooo-create
Copy link
Collaborator

@ooooo-create ooooo-create commented Oct 29, 2023 •
edited by SigureMo
Loading

@paddle-bot
Copy link

paddle-bot bot commented Oct 29, 2023

感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-6274.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明，请参考：飞桨文档预览工具

@ooooo-create ooooo-create mentioned this pull request Oct 29, 2023
Closed
SigureMo
SigureMo reviewed Oct 29, 2023
View reviewed changes
ci_scripts/CAPItools/utils_helper.py Outdated
@@ -99,7 +99,7 @@ def create_and_write_file_cn(self, save_dir, language):
f.write(define_path_text)

if len(self.parameter_dict) != 0:
parameters_text = f'参数\n' f':::::::::::::::::::::'
parameters_text = '参数\n' ':::::::::::::::::::::'
Copy link
Member

@SigureMo SigureMo Oct 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同行不要使用隐式字符串拼接，可以使用 +，或者直接拼接在一起

SigureMo
SigureMo reviewed Oct 29, 2023
View reviewed changes
ci_scripts/CAPItools/utils_helper.py Outdated
@@ -328,7 +330,9 @@ def create_and_write_file_cn(self, save_dir, language):
f.write(fun_note_text)

if len(fun_infor['parameter']) != 0:
parameters_text = "**参数**\n" "\'\'\'\'\'\'\'\'\'\'\'\n"
parameters_text = (
"**参数**\n" + "\'\'\'\'\'\'\'\'\'\'\'\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"\'" -> "'"

这代码看着好蠢，下同

SigureMo
SigureMo approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo SigureMo merged commit 3f05c4a into PaddlePaddle:develop Oct 29, 2023
@ooooo-create ooooo-create mentioned this pull request Oct 30, 2023
Closed
@sunzhongkai588 sunzhongkai588 added the HappyOpenSource 快乐开源活动issue与PR label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docathon]docs 代码风格检查工具对齐 Paddle docs 代码风格检查工具对齐 Paddle
3 participants
@ooooo-create @SigureMo @sunzhongkai588