improve introduction of bfgs args #4677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
cf9f992 to
6db3d94
Compare
dingjiaweiww
approved these changes
May 9, 2022
|
LGTM |
shjNT
approved these changes
May 10, 2022
zhwesky2010
reviewed
May 10, 2022
| @@ -21,16 +21,16 @@ minimize_bfgs | |||
|
|
|||
| 参数 | |||
| ::::::::: | |||
| - **objective_func** - 待优化的目标函数. 接受多元输入并返回一个标量。 | |||
| - **initial_position** (Tensor) - 迭代的初始位置。 | |||
| - **objective_func** (callable) - 待优化的目标函数，接受1维 Tensor 并返回一个标量。 | |||
There was a problem hiding this comment.
这个是1D Tensor，还是一个元素的Tensor？
zhwesky2010
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add more detailed introduction of bfgs/lbfgs args.