【Hackathon 6th No.2】为 Paddle 新增 cholesky_inverse API #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-hit
reviewed
May 20, 2024
| - **参数组合场景** | ||
| - 需要测试单个向量的输入方式 | ||
| - 需要测试 Tensor.cholesky_inverse 的输入方式 | ||
| - 需要测试不同数据类型：float32, float64 |
There was a problem hiding this comment.
inverse 不支持 fp16 bfp16 ～
inverse_kernel.cu
PD_REGISTER_KERNEL(
inverse, GPU, ALL_LAYOUT, phi::InverseKernel, float, double) {}这咋办？
There was a problem hiding this comment.
试了下，不行 ... ...
/home/shun/Documents/Projects/paddle/megemini/Paddle/paddle/phi/kernels/funcs/blas/blas_impl.cu.h(2049): error: class "phi::funcs::CUBlas<phi::dtype::float16>" has no member "MATINV_BATCH"blas_impl.cu.h 里面对于矩阵的逆运算不支持 float16 和 bfloat16 ～
也可参考 torch 的讨论：
pytorch/pytorch#40427
fp16 doesn't provide adequate accuracy for linear algebra functions, and thus libraries (magma and cusolver) don't implement linear algebra functions for fp16 datatype
float16 和 bfloat16 的精度不足以支撑此运算 ～
There was a problem hiding this comment.
了解了 如果原生算子支持的话组合相关的也需要支持，原生不支持的话就不再本次任务范围内了哈
Charles-hit
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Docs
Description
【Hackathon 6th No.2】为 Paddle 新增 cholesky_inverse API
相关接口的 RFC，请评审 ～