Skip to content

Conversation

ADream-ki
Copy link
Contributor

No description provided.

Copy link

paddle-bot bot commented Apr 22, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@ADream-ki
Copy link
Contributor Author

rfc已提交,请review @Charles-hit

Charles-hit
Charles-hit previously approved these changes Apr 29, 2024

# 五、设计思路与实现方案

paddle 目前的 `pad` 算子已经支持 `x`, `pad`, `mode`, `value`, `data_format` 等参数,因此只需指定 value 为 0 以及 mode 为 constant 即可使用 `pad` 算子实现 `zeropad1d/zeropad3d` 。而针对需要实现 `block_diag`的 API,只需在 `zeros` 算子和 `concat`算子即可实现。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

而针对需要实现 block_diag的 API,只需在 zeros 算子和 concat算子即可实现。

只需在,这里不通顺

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

而针对需要实现 block_diag的 API,只需在 zeros 算子和 concat算子即可实现。

只需在,这里不通顺

马上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

而针对需要实现 block_diag的 API,只需在 zeros 算子和 concat算子即可实现。

只需在,这里不通顺

已经修改了

@luotao1 luotao1 merged commit 6aeea18 into PaddlePaddle:master Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants