【Hackathon 6th No.5】为 Paddle 新增 chi2/LKJCholesky API #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from master
xuxinyi389
reviewed
Apr 16, 2024
|
|
||
| ---------------------------------------- | ||
| - `paddle.distribution.LKJCholesky` | ||
| - `Pytorch`和`numpyro` 的`LKJCholesky`实现逻辑基本一致，区别是numpyro多了`sample method`的选择：`_onion`和`_cvine`。 `paddle` 中考虑实现后者 |
There was a problem hiding this comment.
补充下两种采样方式：_onion 和 _cvine 的区别；pytorch没有sample method参数，它使用的是两种中的一种嘛？对相关内容做补充
There was a problem hiding this comment.
已修改
pytorch默认的是onion
cvine的sample方法可以参考: https://ms.mcmaster.ca/canty/seminars/Joe_vinecorr_print.pdf
xuxinyi389
reviewed
Apr 17, 2024
| 参数表： | ||
| - `dim (int)`: 目标相关矩阵的维度。 | ||
| - `concentration (float, optional)`: 集中参数，默认为1.0。这个参数控制了生成的相关矩阵的分布。concentration 越大，生成的矩阵越接近单位矩阵。 | ||
| - `sample_method (str)`:不同采样策略，可选项有：`onion` 和 `cvine` |
There was a problem hiding this comment.
|
LGTM |
This was referenced Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
| API 名称 | paddle.distribution.chi2 / paddle.distribution.LKJCholesky |