Skip to content

Conversation

ccsuzzh
Copy link
Contributor

@ccsuzzh ccsuzzh commented Apr 6, 2024

Copy link

paddle-bot bot commented Apr 6, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

总得来说,本文的除了要描述删除什么,保留什么外,还需介绍原因。删除的,要给出调研完可以删除原因。保留的,要给出哪些地方仍然依赖。因为旧执行器,是很老的代码,没有人完全了解其逻辑,也没有人能够穷举他可能被谁使用到了。所以,只有将调研到的信息列举详细了,Paddle的工程师才能参与评估方案的合理性。更多的,只有文档传递出调研深入、全面的信息,才能让评估者有信心,方案是合理的。

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder wanghuancoder merged commit ead2abf into PaddlePaddle:master Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants