【Hackathon 6th No.7】Add sinc / sinc_ API to Paddle #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxcd
reviewed
Mar 29, 2024
|
|
||
| ## 底层OP设计 | ||
|
|
||
| c++接口为 `_C_ops.sinc` 和 `_C_ops.sinc_` |
There was a problem hiding this comment.
可以的，但是如果按numpy的做法用where来对等于0的元素做替换的话，应该需要临时创建一个和输入一样大小的tensor，这样对于sinc_这个inplace operator而言这一部分又需要占用额外的空间，我想用底层kernel的话可能会省一些空间？
zxcd
reviewed
Apr 9, 2024
| - 正确性验证：可以与 NumPy 的结果对齐； | ||
| - 不同 shape； | ||
| - 前向计算； | ||
| - 计算dtype类型：验证 `float64`，`float32`等； |
There was a problem hiding this comment.
数据类型支持 float16，float32，float64。（paddle.sin 支持 float16，float32，float64)
zxcd
reviewed
Apr 9, 2024
|
|
||
| 不涉及底层OP | ||
|
|
||
| ## API实现方案 |
luotao1
reviewed
Apr 16, 2024
|
|
||
| # 一、概述 | ||
| ## 1、相关背景 | ||
| [NO.7 为 Paddle 新增 PolynomialLR / sinc / sinc_ API](https://github.com/PaddlePaddle/community/blob/master/hackathon/hackathon_6th/【Hackathon%206th】开源贡献个人挑战赛框架开发任务合集.md#no7-为-paddle-新增-polynomiallr--sinc--sinc_-api) |
| x = np.asanyarray(x) | ||
| y = pi * where(x == 0, 1.0e-20, x) | ||
| return sin(y)/y | ||
| ``` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rfcs for sinc / sinc_ API.