【Hackathon 6th No.39】XPINN 迁移至 PaddleScience #835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
72
to
78
| 2. 模型构建 | ||
|
|
||
| 在 `ppsci.arc` 中实现 `XPINN` 模型，并用以下形式调用模型。 | ||
|
|
||
| ```python | ||
| model = ppsci.arch.XPINN | ||
| ``` |
There was a problem hiding this comment.
XPINN本身应该是一种扩展性很强的算法，跟arch绑定感觉不太好，可以考虑参考modulus的做法：https://github.com/NVIDIA/modulus-sym/blob/main/examples/ldc/ldc_2d_domain_decomposition.py。
There was a problem hiding this comment.
好的，有个疑问，需要把 xpinn 算法模块化成 api 吗，还是只在 examples 中实现呢？
There was a problem hiding this comment.
好的，有个疑问，需要把 xpinn 算法模块化成 api 吗，还是只在 examples 中实现呢？
可以是API或者是像modulus这种具备快速扩展到其他案例上的代码块。前者作为API的话，可以考虑归类在PDE模块下，后者可以是像modulus里的一个代码块（函数）。如果做成API的话，可能需要考虑一下怎么设计才是容易扩展又符合正常使用逻辑的，如果是后者，那就只要写一个函数就行了
There was a problem hiding this comment.
已修改，辛苦 review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.