【Hackathon 5th No.4】为 Paddle 新增 masked_scatter API RFC #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoooo0820
reviewed
Sep 18, 2023
…to masked_scatter_rfc
…to masked_scatter_rfc
zoooo0820
reviewed
Sep 19, 2023
…to masked_scatter_rfc
zoooo0820
reviewed
Sep 20, 2023
…to masked_scatter_rfc
…to masked_scatter_rfc
|
@zoooo0820 老师我重新提交了一版RFC，麻烦您抽空看看 |
zoooo0820
reviewed
Sep 27, 2023
…to masked_scatter_rfc
|
@zoooo0820 麻烦review一下 |
…to masked_scatter_rfc
…to masked_scatter_rfc
|
@zoooo0820 老师您看还有问题吗 |
zoooo0820
reviewed
Oct 16, 2023
|
|
||
| ### masked_scatter的初步实现 | ||
|
|
||
| 初步实现如下： |
There was a problem hiding this comment.
这部分初步实现的想法可以搬运到下面API实现方案中
| return paddle.index_put(x, indexs, value.flatten()[:mask.sum()]) | ||
| else: | ||
| """ | ||
| 经过测试，静态图模式下(当x的shape中含有-1)broasdcast_to广播操作失效。但是可以借助乘法来间接实现广播效果 |
There was a problem hiding this comment.
这部分未更新，直接把前面更新后的方案搬到这里来吧
|
|
||
| Tensor.masked_scatter(mask, value) | ||
|
|
||
| Tensor.masked_scatter_(mask, value) |
There was a problem hiding this comment.
@zoooo0820 已全部修改
…to masked_scatter_rfc
…ommunity into masked_scatter_rfc
|
@zoooo0820 @luotao1 麻烦帮忙看看还有问题吗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.