-
Notifications
You must be signed in to change notification settings - Fork 294
[Hackathon No.14] #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hackathon No.14] #53
Conversation
PR格式检查通过,你的PR将接受Paddle专家以及开源社区的review,请及时关注PR动态。 |
已review。文档的整体完成度较好,在补充上述内容后,会更加完善。加油! |
|---|---| | ||
|提交作者<input type="checkbox" class="rowselector hidden"> | yangguohao | | ||
|提交时间<input type="checkbox" class="rowselector hidden"> | 2022-03-19 | | ||
|版本号 | 此设计文档的版本号,如V1.0 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
设计文档的版本号补充一下。
size_average: Optional[bool] = None, | ||
reduce: Optional[bool] = None, | ||
reduction: str = "mean", | ||
) -> Tensor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是不是少了个符号 `
- 2.CPU、GPU下计算一致。 | ||
- 3.各reduction下计算一致 | ||
- 4.各参数输入有效。 | ||
- 5.反向梯度的正确性。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你的PR有最新反馈,请及时修改。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
设计文档已经按要求修改,内容完善。LGTM
你的PR已合入community库,请进行后续代码开发,并将代码提交至Paddle仓库。 |
No description provided.