Skip to content

[Hackathon No.14] #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

yangguohao
Copy link
Contributor

No description provided.

@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@yangguohao yangguohao changed the title Create api_design_for_multilabel_soft_margin_loss.md [Hackathon No.14] Mar 19, 2022
@paddle-bot-old
Copy link

PR格式检查通过,你的PR将接受Paddle专家以及开源社区的review,请及时关注PR动态。
The format inspection passed. Your PR will be reviewed by experts of Paddle and developers from the open-source community. Stay tuned.

@betterpig
Copy link

已review。文档的整体完成度较好,在补充上述内容后,会更加完善。加油!

|---|---|
|提交作者<input type="checkbox" class="rowselector hidden"> | yangguohao |
|提交时间<input type="checkbox" class="rowselector hidden"> | 2022-03-19 |
|版本号 | 此设计文档的版本号,如V1.0 |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

设计文档的版本号补充一下。

size_average: Optional[bool] = None,
reduce: Optional[bool] = None,
reduction: str = "mean",
) -> Tensor:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是少了个符号 `

- 2.CPU、GPU下计算一致。
- 3.各reduction下计算一致
- 4.各参数输入有效。
- 5.反向梯度的正确性。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用已有API组合的方式实现的API不需要验证反向梯度。
78794382d1233dd5b60e09b10703afa2

@paddle-bot-old
Copy link

你的PR有最新反馈,请及时修改。
There’s the latest feedback about your PR. Please check.

Copy link

@betterpig betterpig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

设计文档已经按要求修改,内容完善。LGTM

@betterpig betterpig merged commit f3fc480 into PaddlePaddle:master Mar 23, 2022
@paddle-bot-old
Copy link

你的PR已合入community库,请进行后续代码开发,并将代码提交至Paddle仓库。
Your PR has been merged into community repository. Please move on coding part and submit your code to corresponding repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants