Skip to content

Conversation

KPatr1ck
Copy link
Contributor

PR types

New features

PR changes

APIs

Describe

Add paddlespeech.resource module.

@KPatr1ck KPatr1ck added this to the r1.1.0 milestone May 17, 2022
@KPatr1ck KPatr1ck marked this pull request as draft May 17, 2022 12:41
@mergify mergify bot added the CLI label May 17, 2022
@KPatr1ck
Copy link
Contributor Author

TODO: Compatible with paddlespeech.server

@yt605155624
Copy link
Collaborator

这个变动可能会影响到 server 的函数,因为 server 的有的 excuter 是继承 cli 里面的,默认 cli 里面的 excuter 有 self.pretrained_moedels 这个成员

@yt605155624
Copy link
Collaborator

@lym0302

@mergify mergify bot added the Server label May 19, 2022
@mergify
Copy link

mergify bot commented May 24, 2022

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label May 24, 2022
@KPatr1ck KPatr1ck force-pushed the resource branch 2 times, most recently from 8af2c12 to 38e9371 Compare May 25, 2022 09:43
@mergify mergify bot removed the conflicts label May 25, 2022
@KPatr1ck KPatr1ck marked this pull request as ready for review May 25, 2022 09:44
@KPatr1ck KPatr1ck requested review from lym0302 and zh794390558 May 25, 2022 09:45
@KPatr1ck
Copy link
Contributor Author

KPatr1ck commented May 25, 2022

改动文件较多,需要协助做下cli和server的回归测试。

@mergify
Copy link

mergify bot commented May 26, 2022

This pull request is now in conflict :(

@mergify
Copy link

mergify bot commented May 30, 2022

This pull request is now in conflict :(

@mergify mergify bot added conflicts and removed conflicts labels May 30, 2022
Copy link
Collaborator

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zh794390558 zh794390558 merged commit 0fa32e4 into PaddlePaddle:develop May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants