Skip to content

[vec][score] add plda model #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 19, 2022
Merged

[vec][score] add plda model #1681

merged 9 commits into from
Apr 19, 2022

Conversation

qingen
Copy link
Contributor

@qingen qingen commented Apr 8, 2022

add plda model, fix #1667

@mergify mergify bot added the Vector SID/LID/etc. label Apr 8, 2022
@qingen qingen changed the title add plda model [vec][score] add plda model Apr 8, 2022
@qingen qingen self-assigned this Apr 8, 2022
@qingen qingen added this to the r1.0.0a milestone Apr 8, 2022
@qingen qingen requested a review from LeoMax-Xiong April 8, 2022 10:19
LeoMax-Xiong
LeoMax-Xiong reviewed Apr 10, 2022
View reviewed changes
LeoMax-Xiong
LeoMax-Xiong reviewed Apr 10, 2022
View reviewed changes
LeoMax-Xiong
LeoMax-Xiong reviewed Apr 10, 2022
View reviewed changes
@CLAassistant
Copy link

CLAassistant commented Apr 10, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

LeoMax-Xiong
LeoMax-Xiong previously approved these changes Apr 10, 2022
View reviewed changes
ZeyuChen
ZeyuChen reviewed Apr 10, 2022
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么从SpeechBrain修改的代码没有引入fast版本的代码？
同步再README Acknowledge 页面上补充加上对SpeechBrain优秀设计借鉴的感谢。

@ZeyuChen
Copy link
Member

@qingen 为什么你的CLA还没有通过呢？

@qingen
Copy link
Contributor Author

qingen commented Apr 11, 2022

CLA 这个有些奇怪，不知道是不是中间修改过密钥就不认识了

@qingen
Copy link
Contributor Author

qingen commented Apr 11, 2022

为什么从SpeechBrain修改的代码没有引入fast版本的代码？ 同步再README Acknowledge 页面上补充加上对SpeechBrain优秀设计借鉴的感谢。

当前scoring方法，来自 fast 版本的修改。
OK，补充感谢。

@mergify
Copy link

mergify bot commented Apr 16, 2022

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label Apr 16, 2022
@mergify mergify bot removed the conflicts label Apr 18, 2022
@qingen qingen merged commit 880829f into PaddlePaddle:develop Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeyuChen ZeyuChen ZeyuChen left review comments

@LeoMax-Xiong LeoMax-Xiong LeoMax-Xiong approved these changes

Assignees

@qingen qingen

Labels
Vector SID/LID/etc.
Projects
PaddleSpeech
Status: Done
Milestone
r1.0.0a
Development

Successfully merging this pull request may close these issues.

[vec] add PLDA model
4 participants
@qingen @CLAassistant @ZeyuChen @LeoMax-Xiong